Skip to content

Ensure mix volume is not reset on seeking #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Ensure mix volume is not reset on seeking #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/AlphaTab/Audio/Synth/MidiFileSequencer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public void Seek(double timePosition)
_eventIndex = 0;
var metronomeVolume = _synthesizer.MetronomeVolume;
_synthesizer.NoteOffAll(true);
_synthesizer.Reset();
_synthesizer.ResetSoft();
_synthesizer.SetupMetronomeChannel(metronomeVolume);

SilentProcess(timePosition);
Expand Down Expand Up @@ -345,7 +345,7 @@ public void CheckForStop()
{
var metronomeVolume = _synthesizer.MetronomeVolume;
_synthesizer.NoteOffAll(true);
_synthesizer.Reset();
_synthesizer.ResetSoft();
_synthesizer.SetupMetronomeChannel(metronomeVolume);
OnFinished();
}
Expand Down
32 changes: 32 additions & 0 deletions Source/AlphaTab/Audio/Synth/Synthesis/TinySoundFont.AlphaTab.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,5 +189,37 @@ public void SetupMetronomeChannel(float volume)
ChannelSetMixVolume(SynthConstants.MetronomeChannel, volume);
ChannelSetPresetNumber(SynthConstants.MetronomeChannel, 0, true);
}

/// <summary>
/// Stop all playing notes immediatly and reset all channel parameters but keeps user
/// defined settings
/// </summary>
public void ResetSoft()
{
foreach (var v in _voices)
{
if (v.PlayingPreset != -1 &&
(v.AmpEnv.Segment < VoiceEnvelopeSegment.Release || v.AmpEnv.Parameters.Release != 0))
{
v.EndQuick(OutSampleRate);
}
}

if (_channels != null)
{
foreach (var c in _channels.ChannelList)
{
c.PresetIndex = c.Bank = 0;
c.PitchWheel = c.MidiPan = 8192;
c.MidiVolume = c.MidiExpression = 16383;
c.MidiRpn = 0xFFFF;
c.MidiData = 0;
c.PanOffset = 0.0f;
c.GainDb = 0.0f;
c.PitchRange = 2.0f;
c.Tuning = 0.0f;
}
}
}
}
}