Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
137 commits
Select commit Hold shift + click to select a range
95e9a50
Re-import typescript source tree
Danielku15 Apr 14, 2020
bfe8865
Updated visual test suite
Danielku15 Apr 14, 2020
4256e71
Fix wrong splice calls
Danielku15 Apr 14, 2020
adbefaa
Removed unneeded files, converted in32arrays to number arrays, fixed …
Danielku15 Apr 15, 2020
6419a3d
Fixed audio playback
Danielku15 Apr 15, 2020
0e81250
Dropped flash support, changed soundfont with proper licens for shipp…
Danielku15 Apr 15, 2020
0f0e807
Change font folder case
Danielku15 Apr 15, 2020
6ec56f6
WIP
Danielku15 Apr 17, 2020
87965c2
More c# generation
Danielku15 Apr 18, 2020
d3ed0a7
WIP
Danielku15 Apr 19, 2020
f219a4c
Docs
Danielku15 Apr 19, 2020
506bc90
Statements and type fixes
Danielku15 Apr 19, 2020
4fc0503
Prepared expr tree case
Danielku15 Apr 19, 2020
ae23a0f
Reworked type system
Danielku15 Apr 21, 2020
e277bc1
WIP
Danielku15 Apr 26, 2020
9a43551
Compiling
Danielku15 Apr 26, 2020
b8f6e62
.net version running
Danielku15 Apr 27, 2020
38f5856
Slight improvement on rendering (tests still red)
Danielku15 Apr 27, 2020
46f82c0
Added back C# samples
Danielku15 Apr 27, 2020
35f4596
Cleanup
Danielku15 Apr 27, 2020
9fbc7f7
Setup npm scripts for convenient use
Danielku15 Apr 27, 2020
d7ffe0b
Code style cleanup
Danielku15 Apr 28, 2020
9eaedca
Performance improvements
Danielku15 Apr 28, 2020
a54fc02
Backwards compatibility for events
Danielku15 Apr 28, 2020
d613df4
Adopted tests for CI and added GH actions
Danielku15 Apr 28, 2020
3bea313
Corrected build c# step
Danielku15 Apr 28, 2020
be5ecee
WIP Build scripts
Danielku15 Apr 29, 2020
d674d60
Adjusted version update and nightly npm deploy
Danielku15 Apr 29, 2020
d66bb11
Merge workflows
Danielku15 Apr 29, 2020
cd72919
Correct name
Danielku15 Apr 29, 2020
072a013
Make nightly only run in night and push builds only on main branches
Danielku15 Apr 29, 2020
e58a246
fix cron syntax
Danielku15 Apr 29, 2020
4f6bc1f
Corrected karma conf
Danielku15 Apr 29, 2020
60357fd
Disable visual tests on C# until skia issue is solved
Danielku15 Apr 29, 2020
7f034cd
Merge pull request #1 from Danielku15/feature/typescript-clean
Danielku15 Apr 29, 2020
2502348
Update nightly.yml
Danielku15 Apr 29, 2020
d1766c6
Adjust npm and nuget publish
Danielku15 Apr 29, 2020
019637d
Attempt on using correct run number
Danielku15 Apr 29, 2020
aa5cb5c
Another attempt on publish
Danielku15 Apr 29, 2020
af317ae
Update nightly.yml
Danielku15 Apr 29, 2020
68a292b
Update nightly.yml
Danielku15 Apr 29, 2020
efbc021
Update nightly.yml
Danielku15 Apr 29, 2020
27f9ede
Update and rename nightly.yml to publish.yml
Danielku15 Apr 29, 2020
464bd03
Update publish.yml
Danielku15 Apr 29, 2020
a253779
Update publish.yml
Danielku15 Apr 29, 2020
6fd2a52
Update publish.yml
Danielku15 Apr 29, 2020
730c92c
Update publish.yml
Danielku15 Apr 29, 2020
180e191
Rename package
Danielku15 Apr 29, 2020
4923270
Another try
Danielku15 Apr 29, 2020
eb3bd15
Find out where nupkg is
Danielku15 Apr 29, 2020
742f0e1
Another nuget attempt
Danielku15 Apr 29, 2020
a4fff2c
Publish to NPMJs
Danielku15 May 1, 2020
440a4b3
Changed push URLs
Danielku15 May 1, 2020
fc1b0c5
Corrected variable
Danielku15 May 1, 2020
7ed6fe6
Only publish to myget not consume from
Danielku15 May 1, 2020
58bfe67
Adapted some more props.
Danielku15 May 1, 2020
45723dd
Adopted fix for #354
Danielku15 May 1, 2020
0f19c28
Updated link in readme
Danielku15 May 1, 2020
cd6c0ec
Merge branch 'develop' into feature/typescript
Danielku15 May 1, 2020
fa7761b
Added playground starter to repo
Danielku15 May 3, 2020
89994f0
Updated event names
Danielku15 May 3, 2020
d4fe9c0
Flattened hierarchy
Danielku15 May 3, 2020
8361f63
Updated playground
Danielku15 May 3, 2020
3697c54
Lowercase platform name
Danielku15 May 3, 2020
b2b0b4e
Casing in imports changed
Danielku15 May 3, 2020
e7e7a45
Back to central library exports
Danielku15 May 3, 2020
78ad926
Cleanup and simplifications
Danielku15 May 3, 2020
bd2edcd
IE compat wip
Danielku15 May 6, 2020
f3a5d07
IE11 compatibility restored.
Danielku15 May 6, 2020
dfe9524
Replaced custom list with normal one
Danielku15 May 6, 2020
83d267e
Eliminated or suppressed warnings
Danielku15 May 6, 2020
1de8813
Added script to update csharp version during build
Danielku15 May 6, 2020
6636d6c
Ensure public API of .net version
Danielku15 May 6, 2020
0e7df0c
Linting warning
Danielku15 May 6, 2020
b78f138
Migrated outstanding event.
Danielku15 May 6, 2020
3344607
Extended error system
Danielku15 May 6, 2020
0e64ec3
Minor fixes
Danielku15 May 7, 2020
d8370bf
Publish to nuget.org
Danielku15 May 7, 2020
a194a34
Temporarily activate publish on feature branch
Danielku15 May 7, 2020
02906aa
Force rebuild
Danielku15 May 7, 2020
4d6f703
retry push with no symbols
Danielku15 May 7, 2020
02ddd4c
New options for hiding Notation Elements (#363)
Danielku15 May 14, 2020
b303792
Adds the rendering result to the renderFinished event in JS API (#364)
WolfgangD May 14, 2020
5719c03
Fixed Fermata json serialization
Danielku15 May 14, 2020
8952bc8
Only setup metronome channel if metronome is enabled
Danielku15 May 14, 2020
e5a9db4
Ensure songbook settings are applied after json load
Danielku15 May 14, 2020
d66cada
Fixed wrong tied note chaining which broke songbook bends
Danielku15 May 15, 2020
505ee20
Fixed wrong harmonic value display
Danielku15 May 15, 2020
e89bd04
Aligned brush symbols
Danielku15 May 15, 2020
e712cc2
Aligned pick slides
Danielku15 May 15, 2020
5d11db1
Removed strange sorting behavior, ensure metronome events are only pr…
Danielku15 May 15, 2020
d91f8a9
Added some small paddings to bend glyph
Danielku15 May 15, 2020
de19928
Fixed wrong whammy line positioning
Danielku15 May 15, 2020
7091e18
Reworked tie and slur rendering
Danielku15 May 18, 2020
b335faf
Ensure slur is centered on main tab note
Danielku15 May 18, 2020
4d22a99
Adjusted slur and tie alignment for different scenarios
Danielku15 May 18, 2020
65824f1
Updated visual test suite and fixed minor issues
Danielku15 May 18, 2020
07314bc
Minor fixes on slur handling
Danielku15 May 18, 2020
cb435ad
Added JS specific settings
Danielku15 May 25, 2020
c958afe
Moved soundfont to windows package, small fix on winforms crash
Danielku15 May 25, 2020
7cf40a0
Adjusted logger interface and expose it.
Danielku15 May 25, 2020
faa9768
Fixed compilation
Danielku15 May 25, 2020
c850c53
Temporarily publish develop as latest
Danielku15 May 25, 2020
5afe218
Use dist-tag instead of publish
Danielku15 May 25, 2020
e39b3e4
Avoid pick-stroke on beat after cloning for bend
Danielku15 May 30, 2020
cf0680f
Fixed overlap on pick-strokes
Danielku15 May 30, 2020
ba33c49
Ensure bend slur on tied bend notes.
Danielku15 May 30, 2020
67cd5b8
Use beam direction of guitar pro files
Danielku15 May 30, 2020
06c4718
Optimize wave rendering for brushes
Danielku15 May 30, 2020
3674efb
Fixed wrong note position calculation
Danielku15 May 30, 2020
3ba58c8
Corrected slur positioning to only end on stems for special conditions
Danielku15 May 30, 2020
5852311
Added left-hand-tap and fixed tests
Danielku15 May 31, 2020
187f883
Continue slurs to left-hand-tap notes on separate strings
Danielku15 May 31, 2020
ec31fed
Fixed C# build
Danielku15 May 31, 2020
29d130e
Changed publish temporarily to have latest on newest version
Danielku15 May 31, 2020
d1756ab
Added test for overall notation elements
Danielku15 May 31, 2020
722c9c6
Reworked midi bend value generation
Danielku15 Jun 5, 2020
785b895
Fixed wrong positioning of cursor for grace notes
Danielku15 Jun 7, 2020
8daea59
Smoothened bend audio generation
Danielku15 Jun 7, 2020
1de9895
Fixed issues on buggy seeking (cursor positioning and audio)
Danielku15 Jun 7, 2020
9012748
Fix control to set layout settings correctly
Danielku15 Jun 7, 2020
ea0a78b
Some fixes on the playgroudn
Danielku15 Jun 7, 2020
3a6afe5
Merge branch 'develop' into feature/typescript
Danielku15 Jun 7, 2020
f4a7bf3
Stop deploy on feature branch
Danielku15 Jun 7, 2020
014d931
Adjust comparison to only consider non transparent images for ratio.
Danielku15 Jun 7, 2020
bfb9bc0
Updated playground
Danielku15 Jun 11, 2020
b87c777
Removed unused program change API from Synth
Danielku15 Jun 13, 2020
29c57de
C# compilation compatibility
Danielku15 Jun 13, 2020
2efb154
Remove change program API part 2
Danielku15 Jun 13, 2020
739a3a4
Changed note lookup generation to contain absolute coordinates like o…
Danielku15 Jun 13, 2020
f77482d
Fix on initial rendering for alphaTex
Danielku15 Jun 13, 2020
6f5296a
Fixed C# compilation
Danielku15 Jun 13, 2020
e8c2f8d
Try normal chrome on GH actions for visual tests
Danielku15 Jun 13, 2020
38dfe43
More flexible file loading on C# tests
Danielku15 Jun 13, 2020
b8f2f2a
Added mechanism to store files
Danielku15 Jun 19, 2020
2f6892f
Adjusted thresholds to make tests green again.
Danielku15 Jun 19, 2020
df152b9
Add audio generation for slides (#370)
Danielku15 Jul 5, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
251 changes: 9 additions & 242 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,246 +1,13 @@
root = true
#root = true

[*]
charset = utf-8
end_of_line = crlf
indent_style = space
indent_size = 4
indent_style = space
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
max_line_length = 120
insert_final_newline = true
max_line_length = 100
indent_size = 4

[*.cs]

# Microsoft .NET properties
csharp_preferred_modifier_order=public, private, protected, internal, new, abstract, virtual, sealed, override, static, readonly, extern, unsafe, volatile, async:warning
csharp_style_var_elsewhere = true : warning
csharp_style_var_for_built_in_types = true : warning
csharp_style_var_when_type_is_apparent = true : warning
dotnet_style_predefined_type_for_locals_parameters_members = true : warning
dotnet_style_predefined_type_for_member_access = true : warning
dotnet_style_qualification_for_field = false : warning
dotnet_style_qualification_for_property = false : warning
dotnet_style_qualification_for_method = false : warning
dotnet_style_qualification_for_event = false : warning
dotnet_style_readonly_field = true : warning
dotnet_style_require_accessibility_modifiers = always : warning
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity : warning
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity : warning
dotnet_style_parentheses_in_other_operators = never_if_unnecessary : warning
dotnet_style_object_initializer = true : warning
dotnet_style_collection_initializer = true : warning
dotnet_style_explicit_tuple_names = true : warning
dotnet_style_prefer_inferred_tuple_names = false : warning
dotnet_style_prefer_inferred_anonymous_type_member_names = false : warning
dotnet_style_prefer_auto_properties = true : warning
dotnet_style_prefer_is_null_check_over_reference_equality_method = true : warning
dotnet_style_prefer_conditional_expression_over_assignment = true : warning
dotnet_style_prefer_conditional_expression_over_return = true : warning
dotnet_style_coalesce_expression = true : warning
dotnet_style_null_propagation = true : warning

csharp_style_expression_bodied_methods = false : warning
csharp_style_expression_bodied_constructors = false : warning
csharp_style_expression_bodied_operators = false : warning
csharp_style_expression_bodied_properties = when_on_single_line : warning
csharp_style_expression_bodied_indexers = when_on_single_line : warning
csharp_style_expression_bodied_accessors = when_on_single_line : warning

csharp_style_pattern_matching_over_is_with_cast_check = true : warning
csharp_style_pattern_matching_over_as_with_null_check = true : warning
csharp_style_inlined_variable_declaration = true : warning

csharp_prefer_simple_default_expression = true : warning
#csharp_style_deconstructed_variable_declaration
csharp_style_pattern_local_over_anonymous_function = true : warning

csharp_style_throw_expression = false : warning
csharp_style_conditional_delegate_call = true : warning

csharp_prefer_braces = true : warning

# Formatting conventions
dotnet_sort_system_directives_first = true

csharp_new_line_before_open_brace = all
csharp_new_line_before_else = true
csharp_new_line_before_catch = true
csharp_new_line_before_finally = true
csharp_new_line_before_members_in_object_initializers = true
csharp_new_line_before_members_in_anonymous_types = true
csharp_new_line_between_query_expression_clauses = true

csharp_indent_case_contents = true
csharp_indent_switch_labels = true
csharp_indent_labels = flush_left

csharp_space_after_cast = false
csharp_space_after_keywords_in_control_flow_statements = true
csharp_space_between_method_declaration_parameter_list_parentheses = false
csharp_space_between_method_call_parameter_list_parentheses = false
csharp_space_between_parentheses = false
csharp_space_before_colon_in_inheritance_clause = true
csharp_space_after_colon_in_inheritance_clause = true
csharp_space_around_binary_operators = before_and_after
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
csharp_space_between_method_call_name_and_opening_parenthesis = false
csharp_space_between_method_call_empty_parameter_list_parentheses = false
csharp_space_within_single_line_array_initializer_braces = true

csharp_preserve_single_line_statements = false
csharp_preserve_single_line_blocks = true


# ReSharper properties
resharper_autodetect_indent_settings=true
resharper_braces_for_for=required
resharper_braces_for_foreach=required
resharper_braces_for_ifelse=required
resharper_braces_for_while=required
resharper_csharp_wrap_arguments_style=chop_if_long
resharper_csharp_wrap_parameters_style=chop_if_long
resharper_html_attribute_style=first_attribute_on_single_line
resharper_keep_existing_expr_member_arrangement=false
resharper_keep_existing_initializer_arrangement=false
resharper_max_enum_members_on_line=1
resharper_max_initializer_elements_on_line=1
resharper_normalize_tag_names=true
resharper_no_indent_inside_elements=html,thead,tbody,tfoot
resharper_place_accessorholder_attribute_on_same_line=False
resharper_place_simple_anonymousmethod_on_single_line=false
resharper_place_simple_initializer_on_single_line=false
resharper_use_indent_from_vs=false
resharper_wrap_after_declaration_lpar=true
resharper_wrap_before_first_type_parameter_constraint=true
resharper_wrap_object_and_collection_initializer_style=chop_always

# ReSharper inspection severities
resharper_arguments_style_anonymous_function_highlighting=none
resharper_arguments_style_literal_highlighting=none
resharper_arguments_style_named_expression_highlighting=none
resharper_arguments_style_other_highlighting=none
resharper_arguments_style_string_literal_highlighting=none
resharper_comment_typo_highlighting=none
resharper_identifier_typo_highlighting=none
resharper_localizable_element_highlighting=none
resharper_markup_attribute_typo_highlighting=none
resharper_markup_text_typo_highlighting=none
resharper_non_readonly_member_in_get_hash_code_highlighting=none
resharper_parameter_only_used_for_precondition_check_local_highlighting=none
resharper_partial_method_with_single_part_highlighting=none
resharper_partial_type_with_single_part_highlighting=none
resharper_redundant_anonymous_type_property_name_highlighting=none
resharper_redundant_argument_default_value_highlighting=none
resharper_redundant_attribute_usage_property_highlighting=none
resharper_redundant_case_label_highlighting=none
resharper_string_literal_typo_highlighting=none
resharper_switch_statement_missing_some_cases_highlighting=none
resharper_unused_member_global_highlighting=none
resharper_web_config_module_not_resolved_highlighting=warning
resharper_web_config_type_not_resolved_highlighting=warning
resharper_web_config_wrong_module_highlighting=warning

# .NET naming conventions

# Mostly adapted from Roslyn

# Non-private static fields are PascalCase
dotnet_naming_rule.non_private_static_fields_should_be_pascal_case.severity = warning
dotnet_naming_rule.non_private_static_fields_should_be_pascal_case.symbols = non_private_static_fields
dotnet_naming_rule.non_private_static_fields_should_be_pascal_case.style = non_private_static_field_style

dotnet_naming_symbols.non_private_static_fields.applicable_kinds = field
dotnet_naming_symbols.non_private_static_fields.applicable_accessibilities = public, protected, internal, protected internal, private protected
dotnet_naming_symbols.non_private_static_fields.required_modifiers = static

dotnet_naming_style.non_private_static_field_style.capitalization = pascal_case

# Constants are PascalCase
dotnet_naming_rule.constants_should_be_pascal_case.severity = warning
dotnet_naming_rule.constants_should_be_pascal_case.symbols = constants
dotnet_naming_rule.constants_should_be_pascal_case.style = constant_style

dotnet_naming_symbols.constants.applicable_kinds = field, local
dotnet_naming_symbols.constants.required_modifiers = const

dotnet_naming_style.constant_style.capitalization = pascal_case

# Static readonly fields are PascalCase without prefix
dotnet_naming_rule.static_readonly_fields_should_be_camel_case.severity = warning
dotnet_naming_rule.static_readonly_fields_should_be_camel_case.symbols = static_readonly_fields
dotnet_naming_rule.static_readonly_fields_should_be_camel_case.style = static_readonly_field_style

dotnet_naming_symbols.static_readonly_fields.applicable_kinds = field
dotnet_naming_symbols.static_readonly_fields.required_modifiers = static, readonly

dotnet_naming_style.static_readonly_field_style.capitalization = pascal_case

# Static fields are camelCase and start with _
dotnet_naming_rule.static_fields_should_be_camel_case.severity = warning
dotnet_naming_rule.static_fields_should_be_camel_case.symbols = static_fields
dotnet_naming_rule.static_fields_should_be_camel_case.style = static_field_style

dotnet_naming_symbols.static_fields.applicable_kinds = field
dotnet_naming_symbols.static_fields.required_modifiers = static

dotnet_naming_style.static_field_style.capitalization = camel_case
dotnet_naming_style.static_field_style.required_prefix = _

# Instance fields are camelCase and start with _
dotnet_naming_rule.instance_fields_should_be_camel_case.severity = warning
dotnet_naming_rule.instance_fields_should_be_camel_case.symbols = instance_fields
dotnet_naming_rule.instance_fields_should_be_camel_case.style = instance_field_style

dotnet_naming_symbols.instance_fields.applicable_kinds = field

dotnet_naming_style.instance_field_style.capitalization = camel_case
dotnet_naming_style.instance_field_style.required_prefix = _

# Locals and parameters are camelCase
dotnet_naming_rule.locals_should_be_camel_case.severity = warning
dotnet_naming_rule.locals_should_be_camel_case.symbols = locals_and_parameters
dotnet_naming_rule.locals_should_be_camel_case.style = camel_case_style

dotnet_naming_symbols.locals_and_parameters.applicable_kinds = parameter, local

dotnet_naming_style.camel_case_style.capitalization = camel_case

# Local functions are PascalCase
dotnet_naming_rule.local_functions_should_be_pascal_case.severity = warning
dotnet_naming_rule.local_functions_should_be_pascal_case.symbols = local_functions
dotnet_naming_rule.local_functions_should_be_pascal_case.style = local_function_style

dotnet_naming_symbols.local_functions.applicable_kinds = local_function

dotnet_naming_style.local_function_style.capitalization = pascal_case


# Async methods must end with 'Async'
dotnet_naming_rule.async_methods_must_end_with_async.severity = warning
dotnet_naming_rule.async_methods_must_end_with_async.symbols = method_symbols
dotnet_naming_rule.async_methods_must_end_with_async.style = end_in_async_style

dotnet_naming_symbols.method_symbols.applicable_kinds = method
dotnet_naming_symbols.method_symbols.required_modifiers = async

dotnet_naming_style.end_in_async_style.capitalization = pascal_case
dotnet_naming_style.end_in_async_style.required_suffix = Async

# Interfaces are PascalCase and start with I
dotnet_naming_rule.interfaces_should_be_prefixed_pascal_case.severity = warning
dotnet_naming_rule.interfaces_should_be_prefixed_pascal_case.symbols = interface
dotnet_naming_rule.interfaces_should_be_prefixed_pascal_case.style = interface_style

dotnet_naming_symbols.interface.applicable_kinds = interface

dotnet_naming_style.interface_style.capitalization = pascal_case
dotnet_naming_style.interface_style.required_prefix = I

# By default, name items with PascalCase
dotnet_naming_rule.members_should_be_pascal_case.severity = warning
dotnet_naming_rule.members_should_be_pascal_case.symbols = all_members
dotnet_naming_rule.members_should_be_pascal_case.style = pascal_case_style

dotnet_naming_symbols.all_members.applicable_kinds = *

dotnet_naming_style.pascal_case_style.capitalization = pascal_case
[*.md]
trim_trailing_whitespace = false
63 changes: 0 additions & 63 deletions .gitattributes

This file was deleted.

35 changes: 35 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Build
on:
push:
branches:
- develop
- master
pull_request:

jobs:
build_web:
name: Build and Test Web
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: '12.x'
- run: npm install
- run: npm run build-ci
- run: npm run test-ci

build_csharp:
name: Build and Test C#
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: '12.x'
- uses: actions/setup-dotnet@v1
with:
dotnet-version: '3.1.100'
- run: npm install
- run: npm run build-csharp-ci
- run: npm run test-csharp-ci
Loading