-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add testing harness and e2e scaffolding #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add testing harness and e2e scaffolding #6
Conversation
Summary of ChangesHello @harley, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's reliability and maintainability by establishing a comprehensive testing infrastructure. It introduces both unit testing with Vitest and end-to-end testing with Playwright, ensuring that core functionalities of the extension, from background processes to UI interactions and content rendering, are thoroughly validated. This foundational work will enable more confident development and prevent regressions in future changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does an excellent job of setting up a comprehensive testing harness for the extension, including unit tests with Vitest and end-to-end tests with Playwright. The new test files are well-structured, and the mocking for the chrome API is robust. The configuration files for testing tools are also set up correctly.
I've made a few minor suggestions to improve dependency management, fix a small issue in a test expectation, and make the Playwright configuration more CI-friendly. Overall, this is a fantastic contribution that significantly improves the project's quality and maintainability.
package.json
Outdated
| "@vitest/ui": "^1.6.0", | ||
| "c8": "^9.1.0", | ||
| "happy-dom": "^13.8.3", | ||
| "jsdom": "^24.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have both happy-dom and jsdom as dev dependencies. Your Vitest configuration (vitest.config.ts) is set to use happy-dom as the test environment. Since jsdom is not being used by Vitest and doesn't seem to be a dependency for other testing libraries you've added, you can remove it to keep dependencies clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use Codex here, create a Codex account and connect to github.
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_68d762ba1010832ba001bbaa6714e09f