-
Notifications
You must be signed in to change notification settings - Fork 3
feat(api): create slice complete task (#211) #305
feat(api): create slice complete task (#211) #305
Conversation
…te_slice_CompleteTask_TaskWasCompleted
…te_slice_CompleteTask_TaskWasCompleted
|
This pull request is being automatically deployed with Vercel (learn more). coderscamp-website – ./🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/8gcDksX226BX4jpmwmypbsEet2oK coderscamp-docs – ./🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/Vf17AJEXAaxaDVULtep1WfsQsAhN coderscamp-storybook – ./🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/4C6h43NTruNBa5aHyQZUfbz94VuN |
|
Let's run |
packages/api/src/module/write/learning-materials-tasks/domain/complete-task.spec.ts
Outdated
Show resolved
Hide resolved
…te_slice_CompleteTask_TaskWasCompleted
Codecov Report
@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 87.09% 87.22% +0.12%
==========================================
Files 104 110 +6
Lines 1069 1119 +50
Branches 155 163 +8
==========================================
+ Hits 931 976 +45
- Misses 137 142 +5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MateuszNaKodach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I have submitted this review yesterday. So ignore if some comments are irrelevant for current state.
packages/api/src/module/write/learning-materials-tasks/domain/complete-task.ts
Outdated
Show resolved
Hide resolved
packages/api/src/module/write/learning-materials-tasks/learning-materials-tasks.test-module.ts
Outdated
Show resolved
Hide resolved
.../api/src/module/write/learning-materials-tasks/learning-materials-tasks.write-module.spec.ts
Outdated
Show resolved
Hide resolved
.../api/src/module/write/learning-materials-tasks/learning-materials-tasks.write-module.spec.ts
Outdated
Show resolved
Hide resolved
MateuszNaKodach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work @kacper-cyra ! :) I'm proud of you.
There are little changes to introduce.
packages/api/src/module/read/course-progress/course-progress.rest-controller.ts
Outdated
Show resolved
Hide resolved
packages/api/src/module/read/course-progress/course-progress.read-module.ts
Outdated
Show resolved
Hide resolved
packages/api/src/module/write/learning-materials-tasks/domain/complete-task.spec.ts
Show resolved
Hide resolved
MateuszNaKodach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! :) I've added one small change proposition.
packages/api/src/module/read/course-progress/course-progress.read-module.ts
Outdated
Show resolved
Hide resolved
…te_slice_CompleteTask_TaskWasCompleted
Closes #211