Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@kacper-cyra
Copy link
Contributor

Closes #211

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-211--w-vzvkno September 6, 2021 14:34 Inactive
@vercel
Copy link

vercel bot commented Sep 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/8gcDksX226BX4jpmwmypbsEet2oK
✅ Preview: https://coderscamp-website-git-issue-211-writelearnin-49ccac-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/Vf17AJEXAaxaDVULtep1WfsQsAhN
✅ Preview: https://coderscamp-docs-git-issue-211-writelearningma-0bce50-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/4C6h43NTruNBa5aHyQZUfbz94VuN
✅ Preview: https://coderscamp-storybook-git-issue-211-writelearn-d978ef-coderscamp.vercel.app

@MateuszNaKodach
Copy link
Member

Let's run yarn lint:fix to fix eslint / prettier issues

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #305 (46bd835) into main (4e1d09e) will increase coverage by 0.12%.
The diff coverage is 91.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   87.09%   87.22%   +0.12%     
==========================================
  Files         104      110       +6     
  Lines        1069     1119      +50     
  Branches      155      163       +8     
==========================================
+ Hits          931      976      +45     
- Misses        137      142       +5     
  Partials        1        1              
Flag Coverage Δ
api 83.60% <91.80%> (+0.39%) ⬆️
ui 98.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entation/rest/process-st-events.rest-controller.ts 76.92% <76.92%> (ø)
...e/learning-materials-tasks/domain/complete-task.ts 85.71% <85.71%> (ø)
packages/api/src/app.module.ts 100.00% <100.00%> (ø)
...ead/course-progress/course-progress.read-module.ts 100.00% <100.00%> (ø)
...ared/commands/complete-task.application-command.ts 100.00% <100.00%> (ø)
...tasks/application/complete-task.command-handler.ts 100.00% <100.00%> (ø)
...ials-tasks/learning-materials-tasks.test-module.ts 100.00% <100.00%> (ø)
...als-tasks/learning-materials-tasks.write-module.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1d09e...46bd835. Read the comment docs.

Copy link
Member

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I have submitted this review yesterday. So ignore if some comments are irrelevant for current state.

Copy link
Member

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work @kacper-cyra ! :) I'm proud of you.
There are little changes to introduce.

Copy link
Member

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! :) I've added one small change proposition.

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-211--w-vzvkno September 8, 2021 10:40 Inactive
@kacper-cyra kacper-cyra merged commit 3eca09d into main Sep 8, 2021
@kacper-cyra kacper-cyra deleted the issue-211-_Write_LearningMaterialsTasks_Create_slice_CompleteTask_TaskWasCompleted branch September 8, 2021 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Write | LearningMaterialsTasks] Create slice CompleteTask -> TaskWasCompleted

5 participants