Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@KrystianKjjk
Copy link
Contributor

Closes #287

…issue-287-_Write_EmailConfirmation_REST_API_endpoint_for_ApproveEmailConfirmation
…issue-287-_Write_EmailConfirmation_REST_API_endpoint_for_ApproveEmailConfirmation
@vercel
Copy link

vercel bot commented Sep 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/9cx8M6JK5xqwRPYJXdAe2mrrGg28
✅ Preview: https://coderscamp-storybook-git-issue-287-writeemail-14c2c0-coderscamp.vercel.app

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/FivhmHGBvzL6YxdRZ6z6myqwDnTJ
✅ Preview: https://coderscamp-website-git-issue-287-writeemailco-43ce5a-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/STvQudxjD9UQh1rGN1KdfogzvfDL
✅ Preview: https://coderscamp-docs-git-issue-287-writeemailconfi-24a479-coderscamp.vercel.app

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-287--w-zagpok September 20, 2021 21:16 Inactive
…issue-287-_Write_EmailConfirmation_REST_API_endpoint_for_ApproveEmailConfirmation
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #367 (bd0bce9) into main (d9478f2) will increase coverage by 0.39%.
The diff coverage is 97.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   87.86%   88.25%   +0.39%     
==========================================
  Files         130      138       +8     
  Lines        1491     1558      +67     
  Branches      195      204       +9     
==========================================
+ Hits         1310     1375      +65     
- Misses        181      183       +2     
Flag Coverage Δ
api 86.06% <97.26%> (+0.59%) ⬆️
ui 98.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-registration-was-started.event-handler.service.ts 100.00% <ø> (ø)
...ntation/rest/email-confirmation.rest-controller.ts 83.33% <80.00%> (-4.17%) ⬇️
packages/api/src/app.module.ts 100.00% <100.00%> (ø)
...confirmation-was-approved-event-handler.service.ts 100.00% <100.00%> (ø)
...en-complete-user-registration-automation.module.ts 100.00% <100.00%> (ø)
...ved-then-complete-user-registration.test-module.ts 100.00% <100.00%> (ø)
...en-request-email-confirmation-automation.module.ts 100.00% <100.00%> (ø)
...dule/shared/commands/complete-user-registration.ts 100.00% <100.00%> (ø)
...ts/user-registration-was-completed.domain-event.ts 100.00% <100.00%> (ø)
...ents/user-registration-was-started.domain-event.ts 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4dd65...bd0bce9. Read the comment docs.

Copy link
Member

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks really great!
Let's add some tests and REST API docs for that :)

@MateuszNaKodach MateuszNaKodach merged commit e1801d7 into main Sep 30, 2021
@MateuszNaKodach MateuszNaKodach deleted the issue-287-_Write_EmailConfirmation_REST_API_endpoint_for_ApproveEmailConfirmation branch September 30, 2021 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Write | EmailConfirmation] REST API endpoint for ApproveEmailConfirmation

5 participants