Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Conversation

@KrystianKjjk
Copy link
Contributor

Closes #378

@vercel
Copy link

vercel bot commented Oct 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

coderscamp-website – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-website/8fx9sRyK8uASAhCXzRvCGGXNZwnt
✅ Preview: https://coderscamp-website-git-issue-378-teststrategy-35aea8-coderscamp.vercel.app

coderscamp-storybook – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-storybook/4XFirTRSRNpWDAvh6pSj9J1kSH8P
✅ Preview: https://coderscamp-storybook-git-issue-378-teststrate-2e0fe4-coderscamp.vercel.app

coderscamp-docs – ./

🔍 Inspect: https://vercel.com/coderscamp/coderscamp-docs/8gyeC6PYSR3pxQB5sUrMNDpXE7yv
✅ Preview: https://coderscamp-docs-git-issue-378-teststrategyfor-283464-coderscamp.vercel.app

@KonradSzwarc KonradSzwarc temporarily deployed to coderscamp-issue-378-te-2bvtvp October 8, 2021 23:03 Inactive
@KrystianKjjk KrystianKjjk changed the title refractor(api): test strategy for guarded REST API endpoints (378) feat(api): test strategy for guarded REST API endpoints (378) Oct 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #385 (0ab4809) into main (510ba06) will increase coverage by 2.48%.
The diff coverage is 93.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   87.92%   90.41%   +2.48%     
==========================================
  Files         150      152       +2     
  Lines        1806     1867      +61     
  Branches      236      248      +12     
==========================================
+ Hits         1588     1688     +100     
+ Misses        217      178      -39     
  Partials        1        1              
Flag Coverage Δ
api 88.68% <93.10%> (+3.01%) ⬆️
ui 98.48% <ø> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/api/src/shared/test-utils.ts 97.79% <ø> (-0.24%) ⬇️
packages/api/src/shared/rest-api-test-utils.ts 91.83% <91.83%> (ø)
...-confirmation/domain/approve-email-confirmation.ts 100.00% <100.00%> (ø)
...er-registration/domain/CompleteUserRegistration.ts 100.00% <100.00%> (ø)
...ckages/ui/src/components/EventsCard/EventsCard.tsx 91.66% <0.00%> (ø)
...ntation/rest/email-confirmation.rest-controller.ts 91.66% <0.00%> (+8.33%) ⬆️
...th/automation/user-registration-started.handler.ts 68.75% <0.00%> (+31.25%) ⬆️
packages/api/src/crud/auth/auth-user.repository.ts 100.00% <0.00%> (+33.33%) ⬆️
packages/api/src/crud/auth/local/local.strategy.ts 89.47% <0.00%> (+36.84%) ⬆️
packages/api/src/crud/auth/jwt/jwt.strategy.ts 100.00% <0.00%> (+50.00%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510ba06...0ab4809. Read the comment docs.

Copy link
Member

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed, after some refactor and improvements.

@MateuszNaKodach MateuszNaKodach merged commit a52eb89 into main Oct 22, 2021
@MateuszNaKodach MateuszNaKodach deleted the issue-378-Test_strategy_for_guarded_REST_API_endpoints branch October 22, 2021 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test strategy for guarded REST API endpoints

5 participants