Skip to content

feat(i18n): Chinese Language Support#331

Closed
tianmiao8152 wants to merge 1 commit into
CodesWhat:mainfrom
tianmiao8152:main
Closed

feat(i18n): Chinese Language Support#331
tianmiao8152 wants to merge 1 commit into
CodesWhat:mainfrom
tianmiao8152:main

Conversation

@tianmiao8152
Copy link
Copy Markdown
Contributor

@tianmiao8152 tianmiao8152 commented Apr 29, 2026

Completed the i18n Chinese localization for the existing files

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2026

@tianmiao8152 is attempting to deploy a commit to the CodesWhat Team on Vercel.

A member of the Team first needs to authorize it.

s-b-e-n-s-o-n added a commit that referenced this pull request May 4, 2026
@s-b-e-n-s-o-n
🐛 fix(i18n): seed buildMessages bucket for every supported locale
b97944d 
- 🐛 fix(i18n): initialize messages map from SUPPORTED_LOCALES so non-en namespaces no longer crash on Object.assign(undefined)
- ✨ feat(i18n): close 112 zh translation gaps that landed after PR #331 was opened (containerComponents listContent/stats/updateDialog/eligibilityBadges/maturityBadge/sideTabContent + new groupedViews phase keys + containersView/dashboardView toast keys)

Cherry-picked TianMiao's contribution from PR #331 onto the v1.5-rc17 branch (fork PRs can't satisfy the repo's required CodeQL check).
@s-b-e-n-s-o-n
Copy link
Copy Markdown
Contributor

s-b-e-n-s-o-n commented May 4, 2026

Hi @tianmiao8152 — thank you so much for this contribution! 🙏

I tried to merge directly via GitHub, but the repo's branch ruleset requires a CodeQL check that GitHub does not run on fork PRs (that's a security restriction on Default Code Scanning, not anything specific to your branch). To get the work shipped without holding it up, I cherry-picked your commit onto our active release branch feature/v1.5-rc17 — your authorship is preserved on commit 8f3286b7 and your changes ship in the upcoming v1.5.0-rc.17 release with full attribution in CHANGELOG.md.

A couple of follow-up commits landed on the same branch to round out the locale work:

  • b97944dc — fixed a latent bug in boot/i18n.ts (the messages map was only seeded for en, so the new zh namespace files crashed on Object.assign(undefined, …) once 'zh' was added to SUPPORTED_LOCALES).
  • A subsequent commit added ~110 missing zh translations for keys that landed in the containerComponents/containersView/dashboardView namespaces between when you opened this PR and when it was merged.

Closing this PR since the work has landed via the cherry-pick. Drydock now ships its first non-English locale because of you — much appreciated!

@tianmiao8152
Copy link
Copy Markdown
Contributor Author

tianmiao8152 commented May 4, 2026

Well, this is really great
My effort isn’t actually that much; there are only about a dozen keys that require manual translation
Once v1.5.0 comes out, I will definitely give it a try
Looking forward to our next collaboration
Make Drydock Great Again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-b-e-n-s-o-n s-b-e-n-s-o-n s-b-e-n-s-o-n approved these changes

@biggest-littlest biggest-littlest biggest-littlest approved these changes

@ALARGECOMPANY ALARGECOMPANY Awaiting requested review from ALARGECOMPANY ALARGECOMPANY is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tianmiao8152 @s-b-e-n-s-o-n @biggest-littlest