check-plugin: content-hash dist-lockstep, not mtime#3
Merged
Conversation
The dist-lockstep check compared dist-vs-src mtimes, but git doesn't preserve mtimes — a clone, checkout, or squash-merge rewrites them, producing a false "dist is older than src" warning when the bundle was never actually stale (seen twice after merging PRs #1 and #2). Repeated false warnings train contributors to ignore the gate. Fix: build.mjs stamps a SHA-256 of all src file contents into dist/.srchash; check-plugin recomputes and compares. Checkout-proof, and it catches the real failure (src edited but dist not rebuilt). Shared scripts/lib/src-hash.mjs so the two sides can't drift. Verified: touching a src file (mtime only) stays "up to date"; a content change without rebuild reports "stale". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codestz
added a commit
that referenced
this pull request
Jun 17, 2026
The selfeval routing probe measured systematic UNDER-routing (run #2: 3/7; both decision-hiding traps and a multi-component build one-shotted) — the conductor wasn't applying its own undecided-fork veto. Root cause: the rubric stated escalation as a passive bias ("escalate only on evidence") with no forcing function. Tune (generic, not teaching-to-test): - rebalance Prime Directive #1: a silently-guessed fork ships fragile and invisible; "no reason to escalate" only counts if the check was run. - add a MANDATORY pre-flight escalation checklist (hidden decision / real unknown / multiple components / irreversible) — a YES on any line forbids one-shot. Illustrations are generic, deliberately unlike the fixture tasks. Re-measure pending (run #3). Same-fixture re-measure is suggestive, not proof. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dist-lockstep check compared dist-vs-src mtimes, but git doesn't preserve mtimes — a clone/checkout/squash-merge rewrites them, producing a false "dist is older than src" warning when the bundle was never stale (hit twice, after merging #1 and #2). Repeated false warnings erode the gate.
Fix:
build.mjsstamps a SHA-256 of allsrcfile contents intodist/.srchash;check-pluginrecomputes + compares. Checkout-proof, and it catches the real failure (src edited, dist not rebuilt). Sharedscripts/lib/src-hash.mjsso the two sides can't drift.Verified: touching a src file (mtime only) → "up to date"; a content change without rebuild → "stale".
🤖 Generated with Claude Code