Skip to content

Conversation

Copy link

Copilot AI commented Nov 30, 2025

Addresses code review feedback from #75 about inconsistent parameter naming. Parameters were using PascalCase instead of C# convention camelCase.

Changes

  • CalcDiff: Pic1, Pic2pic1, pic2
  • CalcDiffMaskImage (string): PathPic1, PathPic2pathPic1, pathPic2
  • CalcDiffMaskImage (SKBitmap): Pic1, Pic2pic1, pic2
  • ImagesAreEqual: PathActual, PathExpectedpathActual, pathExpected
  • ImagesHaveEqualSize: PathActual, PathExpectedpathActual, pathExpected

All XML doc comments and method body references updated accordingly.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

…melCase)

Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on 'Diff metadata' pull request Fix parameter naming conventions in ImageCompare.cs Nov 30, 2025
Copilot AI requested a review from stesee November 30, 2025 15:37
@stesee stesee closed this Dec 6, 2025
@stesee stesee deleted the copilot/sub-pr-75-again branch December 6, 2025 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2025
@stesee stesee restored the copilot/sub-pr-75-again branch December 6, 2025 12:55
@stesee stesee deleted the copilot/sub-pr-75-again branch December 6, 2025 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants