feat: allow overriding default fetch function #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradens
approved these changes
Aug 15, 2025
| "X-Apollo-Operation-Name": "query", | ||
| ...config.headers, | ||
| }), | ||
| fetch: config.fetch, |
There was a problem hiding this comment.
I assume if config.fetch is undefined then it'll revert to it's original behaviour properly?
Author
There was a problem hiding this comment.
correct - the underlying graphql-request library provides a default implementation if the configured value is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter to ApiConfig to allows overriding the default fetch implementation with a custom one. This is useful if the consumer wants to mock fetch for tests or alternatively for creating a decorator to the default node fetch implementation for things like logging, metrics, etc.