Skip to content

Fix model not created if the language doesn't change #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Fix model not created if the language doesn't change #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/MonacoEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,12 @@ function MonacoEditor ({
const lastSaveViewState = useLastVersion(saveViewState)
const lastRestoreViewState = useLastVersion(restoreViewState)

const hasValue = fixedCode != null

// Create/Update model
useEffect(() => {
const value = valueRef.current
if (modelUri != null || value != null) {
if (modelUri != null || hasValue) {
const value = valueRef.current
const existingModel = modelUri != null ? monaco.editor.getModel(modelUri) : null
const model = existingModel ?? monaco.editor.createModel(value!, monacoLanguage, modelUri)
if (monacoLanguage != null && model.getLanguageId() !== monacoLanguage) {
Expand All @@ -176,7 +178,7 @@ function MonacoEditor ({
editorRef.current?.setModel(null)
}
return undefined
}, [monacoLanguage, modelUri, valueRef, lastSaveViewState, lastRestoreViewState, disposeModels])
}, [monacoLanguage, modelUri, valueRef, lastSaveViewState, lastRestoreViewState, disposeModels, hasValue])

// Create editor
useEffect(() => {
Expand Down