fix(powershell): mark tests as explicit UTF-8#26
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
OgeonX-Ai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nMarks BOM-less PowerShell files containing non-ASCII characters as UTF-8 with BOM so Windows PowerShell 5.1 parses them deterministically.\n\n## Changes\n- Add UTF-8 BOM encoding without changing script behavior\n- Preserve the existing non-ASCII text exactly\n\n## Why\nPowerShell 5.1 otherwise reads BOM-less scripts through the legacy ANSI/OEM code page, which can corrupt comments, strings, and parser input.\n\n## Validation\n- Parsed every changed script through the PowerShell AST parser\n- Root workspace-health Pester regression suite: 12 passed\n- Git diff whitespace validation passed\n\n## Risks\nEncoding-only change. No runtime logic changed.\n\n## Related\nWorkspace-health non-ascii-ps1 cleanup.\n\n## Reviewer notes\nReview as an encoding-only diff; the visible line replacement is the BOM boundary.