refactor: remove dead _prepend_row code in CSV conversion path#17
Merged
Coding-Dev-Tools merged 1 commit intoMay 18, 2026
Merged
Conversation
The convert() function consumed one row via reader.read_stream() to get CSV field names, then used _prepend_row to re-attach it — but the result was never used (the file is re-read from scratch for the actual conversion). Removed the unused _prepend_row() utility and the dead re-attachment line. The field-order detection itself is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convert() function consumed one row via reader.read_stream() to get
CSV field names, then used _prepend_row to re-attach it — but the
result was never used (the file is re-read from scratch for the actual
conversion). Removed the unused _prepend_row() utility and the dead
re-attachment line. The field-order detection itself is preserved.