Skip to content

Conversation

@stewemetal
Copy link
Contributor

String example = "example";
example.substring(0, example.length); 

This will return the same string, "example", as String.substring takes it's second parameter as non-inclusive, and String.length as an index means (max index + 1).

@CodingAleCR
Copy link
Owner

Exactly the reason why I am working on testing right now. Thanks, I will merge and release as soon as I can.

@CodingAleCR CodingAleCR changed the title Fix last & not being cut off of parameterized URLs Hotfix: Last '&' not being cut off of parameterized URLs Nov 24, 2019
@CodingAleCR CodingAleCR self-assigned this Nov 24, 2019
@CodingAleCR CodingAleCR added the hotfix Fixing something that was not working properly label Nov 24, 2019
Copy link
Owner

@CodingAleCR CodingAleCR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CodingAleCR CodingAleCR merged commit 2e89547 into CodingAleCR:develop Nov 24, 2019
@stewemetal stewemetal deleted the feature/fix-url-params branch November 27, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix Fixing something that was not working properly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants