BugFix: duplicate GET parameters. (Causes invalid URL format) #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi. I was wondering if anyone was having the same issue. I started working on a fix a little back, it will also add testing to the plugin so I can find this issues beforehand. Nice catch as well, will work on merging + releasing this week. Nice job! |
Owner
|
This should be fixed as of #15 and the release 0.2.0 of the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sumary
Doing
client.get(".../api?param=value")ends up doing a request to ".../api?param=value?param=value"About the fix
The problem seems to happen because RequestData.fromHttpRequest(Request request) method parsed the query parameters and put them on 'params', but when recreating a request at toHttpRequest() method it appended the parameters to the url again.
This fix splits the URL at fromHttpRequest method removing the queryParams, so Now
data['url']contains the URL without queryParams. (wich are still accesible throughdata['params']).Note: this fix was tested for this specific use case only.
Fix for older versions
This can be fixed directly in the interceptor code by removing the queryParams from the URL.
Simply add:
data['url'] = data['url'].split("?")[0];at the beggining of the interceptRequest method.