fix: distribute infographic URLs as arrays for multi-image cycling#647
Merged
codercatdev merged 1 commit intomainfrom Mar 13, 2026
Merged
fix: distribute infographic URLs as arrays for multi-image cycling#647codercatdev merged 1 commit intomainfrom
codercatdev merged 1 commit intomainfrom
Conversation
video-pipeline.ts was assigning a single infographicUrl per scene (round-robin). InfographicScene expects infographicUrls (plural array) to cycle through multiple images with crossfade at 4-second intervals. Now distributes URLs evenly across scenes: - 19 images / 4 scenes = ~4-5 images per scene - Last scene gets remaining images - Keeps single infographicUrl for backward compat (first in set) Example: 19 infographics across 4 scenes: Scene 1: images 0-3 (4 images, ~16s of cycling) Scene 2: images 4-7 (4 images) Scene 3: images 8-11 (4 images) Scene 4: images 12-18 (7 images, gets remainder)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Distribute infographic URLs as arrays for multi-image cycling
One file:
lib/services/video-pipeline.tsProblem
video-pipeline.tsassigns a singleinfographicUrlper scene (round-robin):But
InfographicScene(PR #639) expectsinfographicUrls(plural, array) to cycle through multiple images with crossfade at 4-second intervals.Fix
Distribute URLs evenly across scenes as arrays:
Each scene gets
infographicUrls: string[](array for cycling) ANDinfographicUrl: string(first image, backward compat).Impact
infographicUrlstill set for any code reading it