Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
========================================
Coverage 96.82% 96.82%
========================================
Files 236 238 +2
Lines 31002 31129 +127
========================================
+ Hits 30017 30140 +123
- Misses 985 989 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
Implementation SummaryChanges
Deviations from Plan
Open Questions
|
There was a problem hiding this comment.
Pull request overview
Adds a new HamiltonianPath satisfaction model to the graph models set, integrating it with tests, CLI JSON dispatch, an example, and generated schema docs so it can participate in the library’s standard model/solver workflows.
Changes:
- Introduces
HamiltonianPath<G>model with evaluation logic and variant declaration. - Adds unit tests and an executable example, and wires the example into the examples test suite.
- Registers the model in library exports/prelude, CLI alias + JSON dispatch, and updates generated
problem_schemas.json.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/models/graph/hamiltonian_path.rs |
New model implementation + schema registration + variants + tests module hook |
src/unit_tests/models/graph/hamiltonian_path.rs |
Unit tests for evaluation, brute force, serialization, helpers |
src/models/graph/mod.rs |
Exposes the new model module and adds it to graph docs/exports |
src/models/mod.rs |
Re-exports HamiltonianPath from models |
src/lib.rs |
Adds HamiltonianPath to the crate prelude |
problemreductions-cli/src/problem_name.rs |
Adds alias resolution for hamiltonianpath |
problemreductions-cli/src/dispatch.rs |
Adds JSON load/serialize dispatch for HamiltonianPath |
examples/hamiltonian_path.rs |
New example demonstrating construction + brute force enumeration |
tests/suites/examples.rs |
Runs the new example under the examples test suite |
docs/src/reductions/problem_schemas.json |
Generated schema entry for HamiltonianPath |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// | ||
| /// Given a graph G = (V, E), determine whether G contains a Hamiltonian path, | ||
| /// i.e., a simple path that visits every vertex exactly once. | ||
| /// |
Comment on lines
+46
to
+49
| let solution = solver.find_satisfying(&problem); | ||
| assert!(solution.is_some()); | ||
| assert!(problem.evaluate(&solution.unwrap())); | ||
|
|
Comment on lines
+53
to
+55
| for sol in &all { | ||
| assert!(problem.evaluate(sol)); | ||
| } |
Comment on lines
211
to
215
| "MaximumMatching" => deser_opt::<MaximumMatching<SimpleGraph, i32>>(data), | ||
| "MinimumDominatingSet" => deser_opt::<MinimumDominatingSet<SimpleGraph, i32>>(data), | ||
| "GraphPartitioning" => deser_opt::<GraphPartitioning<SimpleGraph>>(data), | ||
| "HamiltonianPath" => deser_sat::<HamiltonianPath<SimpleGraph>>(data), | ||
| "MaxCut" => deser_opt::<MaxCut<SimpleGraph, i32>>(data), |
Comment on lines
+91
to
+94
| fn dims(&self) -> Vec<usize> { | ||
| let n = self.graph.num_vertices(); | ||
| vec![n; n] | ||
| } |
- Document configuration semantics (vertex ordering/permutation) in HamiltonianPath struct doc comment, including dims() encoding rationale - Add explicit `use crate::traits::Problem` import in test_hamiltonian_path_brute_force for consistency with other test functions - Add CLI create support for HamiltonianPath: example_for hint, create_problem match arm, create_random match arm, and updated error message Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
Review Pipeline Report
🤖 Generated by review-pipeline |
Collaborator
Author
Review Pipeline Report
🤖 Generated by review-pipeline |
…-path # Conflicts: # src/lib.rs # src/models/mod.rs
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HamiltonianPathsatisfaction problem model (graph-based,Metric = bool)Fixes #217