Skip to content

Cardioid#256

Merged
shiffman merged 7 commits into
CodingTrain:mainfrom
kfahn22:cardioid
Jun 15, 2022
Merged

Cardioid#256
shiffman merged 7 commits into
CodingTrain:mainfrom
kfahn22:cardioid

Conversation

@kfahn22
Copy link
Copy Markdown
Collaborator

@kfahn22 kfahn22 commented Jun 12, 2022

Adding 133-cardioid

kfahn22 added 2 commits June 12, 2022 07:22
Add 133 cardioid
Adding icons.
@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 12, 2022

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit 19d7be7
🔍 Latest deploy log https://app.netlify.com/sites/codingtrain/deploys/62a9008b21a66f00082d769d
😎 Deploy Preview https://deploy-preview-256--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kfahn22
Copy link
Copy Markdown
Collaborator Author

kfahn22 commented Jun 12, 2022

I checked the deploy log and there errors are related to Image.png files. Do you know what is going on?
Screen Shot 2022-06-12 at 10 08 08 AM

@NwE0kmCE
Copy link
Copy Markdown
Collaborator

NwE0kmCE commented Jun 13, 2022

@kfahn22 It looks like you haven't uploaded an image named pointcloud.png. Once you upload that it should work, unless I'm missing something!
image

@dipamsen
Copy link
Copy Markdown
Member

dipamsen commented Jun 13, 2022

I have no idea, this PR only changes 133-time-tables-cardioid-visualisation, and there is an error in a different directory, 168-the-mandelbulb (and more).
Also, the required image(s) is/are present in this branch. (there are multiple no such file or directory error messages)

Maybe something wrong with the deploy settings? (my PR is also failing)

@NwE0kmCE
Copy link
Copy Markdown
Collaborator

Oh, didn't notice, my bad! @fdoflorenzano do you have any idea what might be causing the issue?

@runemadsen
Copy link
Copy Markdown
Contributor

I'll take a look at this first thing in the morning!

@shiffman
Copy link
Copy Markdown
Member

Hmmmm, looks like something did go wrong somewhere! The same tests are failing with my recent pull request #258 too! I'm investigating now but leaving shortly to have dinner with @runemadsen maybe we can sort it out before our entree comes. 😂

@shiffman
Copy link
Copy Markdown
Member

I see the errors, working on them in a new branch, fixes coming soon!

@shiffman shiffman mentioned this pull request Jun 13, 2022
@shiffman
Copy link
Copy Markdown
Member

#261 should hopefully resolve this 🤞, this (and other recent pull requests) will need to be updated/merged with main once I merge those fixes!

@kfahn22
Copy link
Copy Markdown
Collaborator Author

kfahn22 commented Jun 14, 2022

I have reduced the file size for four of the contribution images.

@shiffman shiffman merged commit c503fe7 into CodingTrain:main Jun 15, 2022
@kfahn22 kfahn22 deleted the cardioid branch July 5, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants