fix(blog): use data attributes for lightbox year/slug#59
Merged
CalvinAllen merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
…parsing The URL doesn't contain the year, so the lightbox couldn't find the original images. Now we pass year and slug from the server-side props via data attributes on the article element.
CalvinAllen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the lightbox not opening when clicking images on blog posts.
Problem
The JavaScript was trying to extract the year from the URL path (
/2026/slug/), but the actual URLs are just/slug/without the year. This causedyearto benulland the lightbox code path that opens the image was never reached.Solution
dateprop on the server sideyearandslugas data attributes on the<article>elementTest plan