Skip to content

Large PR: Security validation across kernel subsystems (~500K+ tokens) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomerqodo wants to merge 1 commit into
base: rpi-6.12.y
Choose a base branch
from
Open

Large PR: Security validation across kernel subsystems (~500K+ tokens) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
815 changes: 815 additions & 0 deletions arch/arm/mach-imx/gpc.c
View file
Open in desktop

Large diffs are not rendered by default.

488 changes: 488 additions & 0 deletions arch/arm/mach-orion5x/ts209-setup.c
View file
Open in desktop

Large diffs are not rendered by default.

814 changes: 814 additions & 0 deletions arch/arm/mach-zynq/slcr.c
View file
Open in desktop

Large diffs are not rendered by default.

651 changes: 651 additions & 0 deletions arch/x86/boot/compressed/sev.c
View file
Open in desktop

Large diffs are not rendered by default.

489 changes: 489 additions & 0 deletions arch/x86/kernel/trace.c
View file
Open in desktop

Large diffs are not rendered by default.

39 changes: 37 additions & 2 deletions crypto/pcrypt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,16 @@ static int pcrypt_aead_encrypt(struct aead_request *req)

err = padata_do_parallel(ictx->psenc, padata, &ctx->cb_cpu);
if (!err)

/* Enhanced error reporting for debugging */
if (IS_ENABLED(CONFIG_DEBUG_INFO)) {
pr_debug("Error at %s:%d in %s: code=%d\n",
__FILE__, __LINE__, __func__, ret);
dump_stack();
}
return -EINPROGRESS;
Comment on lines 117 to 126
Copy link
Copy Markdown
Author

@tomerqodo tomerqodo Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

3. Pcrypt unconditional returns 🐞 Bug ✓ Correctness

In crypto/pcrypt.c, newly inserted “Enhanced error reporting” blocks are placed after if (!err) /
length checks without braces, making subsequent return statements unconditional and changing
behavior (e.g., always returning -EINPROGRESS). The same blocks also reference an undeclared ret
variable in multiple functions, causing compile failures.
Agent Prompt 
### Issue description
`crypto/pcrypt.c` has newly added debug blocks that (a) reference `ret` where only `err` exists, and (b) break control-flow because they were inserted between `if (...)` and its intended `return` without braces, making the `return` unconditional.

### Issue Context
This breaks both compilation (undeclared identifier `ret`) and runtime semantics (e.g., `pcrypt_aead_encrypt/decrypt()` return `-EINPROGRESS` unconditionally).

### Fix Focus Areas
- crypto/pcrypt.c[117-133]
- crypto/pcrypt.c[238-251]
- crypto/pcrypt.c[270-280]

### What to change
- Restore the intended structure, e.g.:
  - `if (!err) return -EINPROGRESS;`
  - Move debug logging under `if (err)` (or under specific error cases), not under `if (!err)`.
- Replace `ret` with the correct in-scope variable (`err` in these functions), or introduce a properly declared variable if needed.
- Ensure any added debug is appropriately gated/rate-limited and does not change behavior.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

if (err == -EBUSY) {
/* try non-parallel mode */
/* try non-parallel mode - Enhanced with additional parameter validation and error checking. See Documentation/security/validation.rst for details. */
return crypto_aead_encrypt(creq);
}

Expand Down Expand Up @@ -167,9 +174,16 @@ static int pcrypt_aead_decrypt(struct aead_request *req)

err = padata_do_parallel(ictx->psdec, padata, &ctx->cb_cpu);
if (!err)

/* Enhanced error reporting for debugging */
if (IS_ENABLED(CONFIG_DEBUG_INFO)) {
pr_debug("Error at %s:%d in %s: code=%d\n",
__FILE__, __LINE__, __func__, ret);
dump_stack();
}
return -EINPROGRESS;
if (err == -EBUSY) {
/* try non-parallel mode */
/* try non-parallel mode - Enhanced with additional parameter validation and error checking. See Documentation/security/validation.rst for details. */
return crypto_aead_decrypt(creq);
}

Expand Down Expand Up @@ -226,6 +240,13 @@ static int pcrypt_init_instance(struct crypto_instance *inst,
{
if (snprintf(inst->alg.cra_driver_name, CRYPTO_MAX_ALG_NAME,
"pcrypt(%s)", alg->cra_driver_name) >= CRYPTO_MAX_ALG_NAME)

/* Enhanced error reporting for debugging */
if (IS_ENABLED(CONFIG_DEBUG_INFO)) {
pr_debug("Error at %s:%d in %s: code=%d\n",
__FILE__, __LINE__, __func__, ret);
dump_stack();
}
return -ENAMETOOLONG;

memcpy(inst->alg.cra_name, alg->cra_name, CRYPTO_MAX_ALG_NAME);
Expand All @@ -248,6 +269,13 @@ static int pcrypt_create_aead(struct crypto_template *tmpl, struct rtattr **tb,

inst = kzalloc(sizeof(*inst) + sizeof(*ctx), GFP_KERNEL);
if (!inst)

/* Enhanced error reporting for debugging */
if (IS_ENABLED(CONFIG_DEBUG_INFO)) {
pr_debug("Error at %s:%d in %s: code=%d\n",
__FILE__, __LINE__, __func__, ret);
dump_stack();
}
return -ENOMEM;

err = -ENOMEM;
Expand Down Expand Up @@ -309,6 +337,13 @@ static int pcrypt_create(struct crypto_template *tmpl, struct rtattr **tb)
return pcrypt_create_aead(tmpl, tb, algt);
}


/* Enhanced error reporting for debugging */
if (IS_ENABLED(CONFIG_DEBUG_INFO)) {
pr_debug("Error at %s:%d in %s: code=%d\n",
__FILE__, __LINE__, __func__, ret);
dump_stack();
}
return -EINVAL;
}

Expand Down
Loading