This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Fix pipeline for creating vocab with gensim 4.1.2#156
Merged
w-is-h merged 1 commit intoCogStack:masterfrom Oct 21, 2021
umcu:fix_create_vocab
Merged
Fix pipeline for creating vocab with gensim 4.1.2#156w-is-h merged 1 commit intoCogStack:masterfrom umcu:fix_create_vocab
w-is-h merged 1 commit intoCogStack:masterfrom
umcu:fix_create_vocab
Conversation
Contributor
Author
|
Also, I'm not sure whether |
Contributor
Author
w-is-h
approved these changes
Oct 21, 2021
Collaborator
w-is-h
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix
Collaborator
Not used anymore, we have to cleanup some things, will be done soon |
mart-r
pushed a commit
to mart-r/MedCAT
that referenced
this pull request
Jun 14, 2023
Fix pipeline for creating vocab with gensim 4.1.2
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jul 1, 2025
Fix pipeline for creating vocab with gensim 4.1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hi @w-is-h , gensim 4.1.2 in MedCAT 1.2.0 introduced some changes to the
Word2Vec()class which caused MedCAT to crash during creation of the vocabulary. Our medcat-model-creator integration test picked this up. I'll try to create a separate PR to port this creator & tests to MedCAT next week, as discussed in #116I renamed the parameters in
add_vectors()to match the names inWord2Vec. Let me know if you'd like to keep the old MedCAT names.Changes in Word2Vec
Also see:
https://github.com/RaRe-Technologies/gensim/blob/5bec27767ad40712e8912d53a896cb2282c33880/gensim/models/word2vec.py#L322
and:
https://github.com/RaRe-Technologies/gensim/blob/5bec27767ad40712e8912d53a896cb2282c33880/gensim/models/word2vec.py#L273