This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Merged
Conversation
Only use Base_tokenizer where needed / applicable
…k - with correct tokenizer
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jun 24, 2025
* CU-86994t45r: Update RelCAT implementation. Only use Base_tokenizer where needed / applicable * CU-86994t45r: Redo init of data paths for RelCAT when loading off disk - with correct tokenizer * CU-86994t45r: Add comment regarding data paths / tokenizer * CU-86994t45r: Add method to load base RelExtr component using pre-existing config * CU-86994t45r: Add legacy converter for RelCAT * CU-86994t45r: Add RelCAT conversion to overall converter * CU-86994t45r: Allow RelCAT to be loaded from disk as part of model pack * CU-86994t45r: Add test for RelCAT in model pack along with legacy conversion * CU-86994t45r: Add note regarding rel cat conversion tests * CU-86994t45r: Fix argument name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RelCAT conversion.
Tests are done within:
They involve downloading a RelCAT model from S3 (it's 250MB or so), converting it, adding to model pack, and saving model pack with it. And subsequently loading both the RelCAT model separately as well as loading the whole model pack and ensuring it has a RelCAT addon.