CU-869b5ncen: fix bugs, beginnings of a test for api backend #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| logger.error(f"Failed to upload projects export: {str(e)}", exc_info=e) | ||
| return Response(f"Failed to upload projects export: {e.message}", 500) | ||
| logger.error(f"Failed to upload projects export: {e}", exc_info=e) | ||
| return Response(f"Failed to upload projects export: {e}", 500) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
This autofix suggestion was applied.
Show autofix suggestion
Hide autofix suggestion
This autofix suggestion was applied.
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 19 days ago
To fix the issue, do not include the exception message or stack trace in HTTP responses sent to users. Instead, return a generic error message to the user, while ensuring that the exception details are fully logged server-side for debugging.
Steps:
- In the
except Exception as e:block inupload_deployment, change the return value fromResponse(f"Failed to upload projects export: {e}", 500)to something generic, e.g.Response("Failed to upload projects export.", 500), omitting variable data. - No new methods or imports are required, as logging is already handled above the return statement with the logger.
Only medcat-trainer/webapp/api/api/views.py, lines 709-711, need changing.
Suggested changeset
1
medcat-trainer/webapp/api/api/views.py
| @@ -708,7 +708,7 @@ | ||
| return Response("successfully uploaded", 200) | ||
| except Exception as e: | ||
| logger.error(f"Failed to upload projects export: {e}", exc_info=e) | ||
| return Response(f"Failed to upload projects export: {e}", 500) | ||
| return Response("Failed to upload projects export.", 500) | ||
|
|
||
|
|
||
| @api_view(http_method_names=['GET', 'DELETE']) |
Copilot is powered by AI and may make mistakes. Always verify output.
tomolopolis
committed this autofix suggestion 19 days ago.
tomolopolis
force-pushed
the
fix-meta-anno-export-upload
branch
from
937fb32 to
08f9752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes meta-annotation upload bug, where if meta annotations are exported (or generated) in an export, and uploaded to a trainer instance they wouldn't appear.
ALSO - added a test for this API, and added to GHA jobs. The start of having the backend unit tested...
Note
Fixes meta-annotation import bug and adds Django backend unit tests with CI/CD integration.
api/data_utils.py: setmeta_taskcorrectly, persistacc, and linkmeta_task_value.InvalidParameterErrorand raise when nocdb/vocab/modelpackprovided.api/views.pyfor uploads.upload_projects_exportinapi/tests/test_data_utils.pywith fixturefixtures/example.json; cover CDB/Vocab, ModelPack, members, validated docs, custom suffix, empty projects, missing params, and unknown users.api/tests.pyplaceholder.test-backendjob (Python 3.11, spaCy model) to CI, QA, and release workflows; gate builds on it.Written by Cursor Bugbot for commit 08f9752. This will update automatically on new commits. Configure here.