CU-8699nk284 Update MedCAT service to v2 #27
Conversation
… of en_core_sci_lg
mart-r
force-pushed
the
CU-8699nk284-update-service-to-v2
branch
from
93557a5 to
0ce5060
Compare
This reverts commit 0f9cfc2.
alhendrickson
left a comment
alhendrickson
left a comment
There was a problem hiding this comment.
I'm surprised it's working with the v1 pack I've put in, but great that it is! I'd look to bundle a v2 pack now in there as well for the testing
| COPY ./requirements.txt /cat | ||
|
|
||
| # NOTE: need git for URL based installs | ||
| RUN apt-get update && apt-get install -y git |
There was a problem hiding this comment.
For a later improvement, I guess we can switch to the multi stage builds like you made for other things. This at least is highlighting the build dependency vs runtime anyway. Though I get here it's going to change like 0.01% of the total image size...
There was a problem hiding this comment.
Well, in the long (or medium) run, we should be able to remove this. Once we're installing based on PyPI instead of a GH link, we don't need git anymore.
Yeah, we're currently doing everything to ease people in to moving to v2. And that includes converting v1 models on the fly. Though if we want this to run for v2, then changing the model is a good idea. Though I'd tackle that in a more global way. There's a lot of these workflows right now that run on old v1 models that get converted on the fly. PS: |
Changes: - Added 6 new tasks for Sprint 3 Phase 2 (Advanced Query Parsing) - Fixed duplicate task ID CogStack#19 → renamed new task to CogStack#25 - Updated Next available ID: 26 → 31 - Updated header stats: 6 pending, 24 completed Tasks Added: - CogStack#25 [developer] QueryBuilder Basic Structure (2h) - CogStack#26 [developer] Simple Keyword Query Building (2h) - CogStack#27 [developer] Phrase Query Building (2h) - CogStack#28 [developer] Field-Specific Query Building (2h) - CogStack#29 [auditor] Review QueryBuilder compliance (1h) - CogStack#30 [tester] QueryBuilder integration tests (2h) Rationale: - Continue Sprint 3 Full-Text Search implementation - Phase 1 complete, Phase 2 next (Advanced Query Parsing) - Tasks follow TDD approach (tests first) - Include auditor and tester agents for validation - Enable autonomous loop to continue development Spec Reference: - .specify/tasks/sprint-3-full-text-search-tasks.md (Phase 2) - .specify/plans/sprint-3-full-text-search-plan.md (30 hours Phase 2) Next Steps: - Autonomous loop will spawn developer agent for task CogStack#25 - Continue through tasks CogStack#26-30 automatically - No manual intervention required (following user feedback)
Update MedCAT service to run on MedCAT v2.
Currently just hard coded version.