-
Notifications
You must be signed in to change notification settings - Fork 5
CU-8699nk284 Update MedCAT service to v2 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
651d503
CU-8699nk284: Update requirements to v2
mart-r d8caef7
CU-8699nk284: Add DeID requirement
mart-r 238502a
CU-8699nk284: Update code to be in line with v2
mart-r f18b216
CU-8699nk284: Update README with v2 link
mart-r 35fe531
CU-8699nk284: Update README with v2 link (2nd place)
mart-r 87893fe
CU-8699nk284: Fix examples tutorial link
mart-r 4b2d5f2
CU-8699nk284: Update model card stuff for v2 compatibility
mart-r 0f9cfc2
CU-8699nk284: Avoid running docker hub push on pull requets
mart-r 3740d4c
CU-8699nk284: Fix typo in import path
mart-r d3b0f9c
CU-8699nk284: Fix further typo
mart-r 3689b4d
CU-8699nk284: Fix access path for MetaCAT config categery name
mart-r b6434df
CU-8699nk284: Update to latest medcat v2 release
mart-r 273ce6a
CU-8699nk284: Bump supported version to latest (to fix legacy CDB con…
mart-r 289923d
U-8699nk284: Fix some config access
mart-r 0b60b34
U-8699nk284: Fix some more config access
mart-r 4772ac2
Merge branch 'main' into CU-8699nk284-update-service-to-v2
mart-r f3666c7
CU-8699nk284: Bump dependency to latest
mart-r 2ac04e4
CU-8699nk284: Update to latest v2 version
mart-r 1da7ebf
Merge branch 'main' into CU-8699nk284-update-service-to-v2
mart-r c80ca15
CU-8699nk284: Bump to latest medcat version again (this time finally,…
mart-r cb9d356
CU-8699nk284: Fix config access
mart-r 0370641
CU-8699nk284: Mock CDB load during test to use en_core_web_md instead…
mart-r 2e44eec
CU-8699nk284: [TEMP] Add debug output
mart-r 63081e5
CU-8699nk284: Add client test within mocked / changed spacy model con…
mart-r 14798c4
CU-8699nk284: [TEMP] Add debug (more) output
mart-r d9becbd
CU-8699nk284: Mock a different method and more generally during testing
mart-r dc0df31
CU-8699nk284: Fix import during testing
mart-r 28539c3
Merge branch 'main' into CU-8699nk284-update-service-to-v2
mart-r 015205d
CU-8699nk284: Remove (most of) the debug output
mart-r 49af0dc
CU-8699nk284: Bump requirements to latest
mart-r 9130864
CU-8699nk284: Update ultiprocessing method to v2
mart-r a62f92f
CU-8699nk284: Fix keyword argument name
mart-r 05b02a5
CU-8699nk284: Update multiprocessing
mart-r 34e8292
Merge branch 'main' into CU-8699nk284-update-service-to-v2
mart-r bf677cc
CU-8699nk284: Update to latest MedCAT version
mart-r edf108f
Merge branch 'main' into CU-8699nk284-update-service-to-v2
mart-r ea9834c
CU-8699nk284: Update to latest requirements
mart-r 43a9e28
CU-8699nk284: Use newer python in workflow
mart-r f6f6528
Merge branch 'main' into CU-8699nk284-update-service-to-v2
mart-r 0ce5060
CU-8699nk284: Bump requirements to latest
mart-r 20f9601
Merge branch 'main' into CU-8699nk284-update-service-to-v2
mart-r e792b20
CU-8699nk284: Bump requirements to latest
mart-r d014bb9
Revert "CU-8699nk284: Avoid running docker hub push on pull requets"
mart-r 803d417
CU-8699nk284: Fix Dockerfile for GitHub URL-based installs
mart-r 04919d9
CU-8699nk284: Fix hash attribute path
mart-r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a later improvement, I guess we can switch to the multi stage builds like you made for other things. This at least is highlighting the build dependency vs runtime anyway. Though I get here it's going to change like 0.01% of the total image size...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, in the long (or medium) run, we should be able to remove this. Once we're installing based on PyPI instead of a GH link, we don't need
gitanymore.