CU-8699q97m0 Fix supervised train negative examples #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mart-r
added a commit
that referenced
this pull request
Jul 8, 2025
* CU-8699q97m0: Fix negative examples in supervised training data * CU-8699q97m0: Show better exceptions for KeyError when doing supervised training
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue when using a trainer export that had a negative sample such that the within the model that's being trained the name used didn't actually match to the CUI incorrectly linked by the model in the trainer.
That is to say, if the model in the trainer incorrectly identified "ABC" as CUI "C1", the annotator then corrected it. But the model being trained doesn't know that "ABC" is a synonym for "C1".
This PR fixes that.
It also adds a little bit of extra context to errors if something similar were to happen again.