tests(medcat): CU-869d8wft4 Add tests to name count during supervised training#435
Merged
Merged
Conversation
Contributor
|
LGTM - you know the embedding linker doesn't increase these training counts, right? |
adam-sutton-1992
approved these changes
May 12, 2026
Collaborator
Author
Yeah, that's fine. These are only really applicable for the vector context model. Perhaps they should be kept separate from the core structure. But it is what it is for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to have not been working in MedCAT==2.5.3, see this discourse thread.
However, at a closer look it turned out this was in latest state of the codebase.
At a closer look it looks like this was fixed by #374 and released in v2.7.0 (April 1st).
I verified by checking that the issue does exist in v2.6.0 but does not in v2.7.0.
Nevertheless, I felt like adding tests for this would be appropriate.