Merged
Conversation
ghost
requested a review
from
added 2 commits
January 14, 2022 15:24
twalshcsv
approved these changes
Jan 14, 2022
Contributor
twalshcsv
left a comment
twalshcsv
left a comment
There was a problem hiding this comment.
Small comments - nothing that would stop this from getting in
jmaqs-selenium/src/main/java/com/magenic/jmaqs/selenium/WebDriverFactory.java
Show resolved
Hide resolved
| import com.magenic.jmaqs.utilities.helper.Config; | ||
| import com.magenic.jmaqs.utilities.helper.ConfigSection; | ||
| import com.magenic.jmaqs.utilities.helper.StringProcessor; | ||
| import io.github.bonigarcia.wdm.WebDriverManager; |
Contributor
There was a problem hiding this comment.
We should have a fall back in case WebDriverManager functionality is blocked.
This could easily be put in a different PR.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the WebDriverManager into a fully adopted dependency.