Merged
Conversation
updated comments
import updates
twalshcsv
reviewed
Apr 14, 2022
...selenium/src/test/java/com/cognizantsoftvision/maqs/selenium/SeleniumTestObjectUnitTest.java
Outdated
Show resolved
Hide resolved
twalshcsv
reviewed
Apr 14, 2022
...enium/src/test/java/com/cognizantsoftvision/maqs/selenium/SeleniumDriverManagerUnitTest.java
Outdated
Show resolved
Hide resolved
twalshcsv
reviewed
Apr 14, 2022
maqs-selenium/src/test/java/com/cognizantsoftvision/maqs/selenium/SeleniumConfigUnitTest.java
Outdated
Show resolved
Hide resolved
twalshcsv
reviewed
Apr 14, 2022
maqs-base/src/test/java/com/cognizantsoftvision/maqs/base/BaseTestObjectUnitTest.java
Outdated
Show resolved
Hide resolved
twalshcsv
reviewed
Apr 14, 2022
maqs-appium/src/test/java/com/cognizantsoftvision/maqs/appium/MobileDriverManagerUnitTest.java
Outdated
Show resolved
Hide resolved
twalshcsv
reviewed
Apr 14, 2022
maqs-appium/src/test/java/com/cognizantsoftvision/maqs/appium/AppiumUtilitiesUnitTest.java
Show resolved
Hide resolved
twalshcsv
reviewed
Apr 14, 2022
maqs-appium/src/test/java/com/cognizantsoftvision/maqs/appium/AppiumDriverFactoryUnitTest.java
Outdated
Show resolved
Hide resolved
twalshcsv
reviewed
Apr 14, 2022
maqs-appium/src/test/java/com/cognizantsoftvision/maqs/appium/AppiumConfigUnitTest.java
Show resolved
Hide resolved
twalshcsv
suggested changes
Apr 14, 2022
Contributor
twalshcsv
left a comment
twalshcsv
left a comment
There was a problem hiding this comment.
Overall like the change but see some small issues - See comments for issue details
…ce/maqs-java into Add_Interfaces
twalshcsv
approved these changes
Apr 14, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added interfaces to base, appium, cucumber, selenium, logger, perf timer, and webservices.
Updated some comments
renamed ManagerDictionary to ManagerStore to match maqs-dotnet naming