Merged
Conversation
lots of comments
# Conflicts: # maqs-selenium/src/test/java/com/cognizantsoftvision/maqs/selenium/WebDriverFactoryUnitTest.java
# Conflicts: # maqs-base/src/main/java/com/cognizantsoftvision/maqs/base/BaseTestObject.java # maqs-base/src/main/java/com/cognizantsoftvision/maqs/base/ITestObject.java
# Conflicts: # maqs-base/src/main/java/com/cognizantsoftvision/maqs/base/BaseTestObject.java
# Conflicts: # docker/MAQSService/MainTestService/obj/staticwebassets.pack.sentinel # maqs-selenium/src/test/java/com/cognizantsoftvision/maqs/selenium/ElementHandlerUnitTest.java
…t_support # Conflicts: # maqs-playwright/src/main/java/com/cognizantsoftvision/maqs/playwright/PageDriverFactory.java
twalshcsv
reviewed
May 4, 2022
| public Object[] browserType() { | ||
| ArrayList<PlaywrightBrowser> data = new ArrayList<>(); | ||
| data.add(PlaywrightBrowser.CHROMIUM); | ||
| data.add(PlaywrightBrowser.EDGE); |
Contributor
There was a problem hiding this comment.
This will not work on the Linux test agents
twalshcsv
reviewed
May 4, 2022
|
|
||
| @Test(groups = TestCategories.PLAYWRIGHT) | ||
| public void defaultOptionsUseProxy() { | ||
| Config.addTestSettingValues(Collections.singletonMap("UseProxy", "Yes"), |
Contributor
There was a problem hiding this comment.
This is a very very very bad idea.
You override a pretty low level setting and just leave it set - I am guessing this is why so many tests started failing when these changes got pushed
…ource/maqs-java into playright_support
twalshcsv
approved these changes
May 4, 2022
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create playwright module for testing and support