Merged
Conversation
# Conflicts: # maqs-utilities/src/main/java/com/cognizantsoftvision/maqs/utilities/logging/FileLogger.java # maqs-utilities/src/main/java/com/cognizantsoftvision/maqs/utilities/logging/HtmlFileLogger.java # maqs-utilities/src/main/java/com/cognizantsoftvision/maqs/utilities/performance/PerfTimerCollection.java
twalshcsv
suggested changes
Apr 26, 2022
Contributor
twalshcsv
left a comment
twalshcsv
left a comment
There was a problem hiding this comment.
For the lost part, love it
That being said you should restore inherit docs, improves our long term maintenance
maqs-utilities/src/test/java/com/cognizantsoftvision/maqs/utilities/LoggingConfigUnitTest.java
Outdated
Show resolved
Hide resolved
maqs-utilities/src/main/java/com/cognizantsoftvision/maqs/utilities/logging/FileLogger.java
Show resolved
Hide resolved
Closed
# Conflicts: # maqs-selenium/src/test/java/com/cognizantsoftvision/maqs/selenium/WebDriverFactoryUnitTest.java
twalshcsv
suggested changes
May 4, 2022
maqs-selenium/src/main/java/com/cognizantsoftvision/maqs/selenium/SeleniumDriverManager.java
Outdated
Show resolved
Hide resolved
twalshcsv
approved these changes
May 4, 2022
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix code smells for build stability