Skip to content
This repository was archived by the owner on Feb 25, 2023. It is now read-only.

Conversation

@fengtality
Copy link
Contributor

This PR changes changes the buy and sell functions for Uniswap and Balancer so that they only return the transaction hash txHash. Afterwards, the client poll for status by passing txHash as param in a POST request to /eth/get-receipt, which returns the transaction status.

If transaction has not been confirmed, output is:

confirmed: false,
receipt: {}

If transaction has been confirmed, output is:

confirmed: true,
receipt: {
  gasUsed: int,
  blockNumber: int,
  confirmations: int,
  status: 1, // 0 = fail, 1 = success
}

Copy link
Contributor

@gyozajiro gyozajiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyozajiro gyozajiro merged commit 7bdf537 into development Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants