(feat) standard endpoints & consolidate protocol library functions #37

gyozajiro · 2021-01-30T13:33:17Z

merge balancer & uniswap endpoint to under /eth
consolidate functions on balancer, uniswap swaps price lookup
cache swap pool as class property
replace token contract address with token symbol on request param
add mainnet token list (1inch)
add maxswaps, ethGasStation api, gas level param to .env

* merge balancer & uniswap endpoint to under /eth * consolidate functions on balancer, uniswap swaps price lookup * cache swap pool as class property * replace token contract address with token symbol on request param * add mainnet token list (1inch) * add maxswaps, ethGasStation api, gas level param to .env

gyozajiro · 2021-01-30T13:45:21Z

API Endpoints are consolidated as below:

General Ethereum API

# get ethereum-based wallet balances
/eth/balances

# get token allowance amount
/eth/allowances

# approve token allowance amount
/eth/approve

# get tx status update
/eth/poll

Balancer/Uniswap API

# initiate swap pool, auto-approve allowance
eth/{protocol}/start

# lookup buy/sell price
eth/{protocol}/price

# execute buy/sell trade
eth/{protocol}/trade

Terra API

# 
terra/start
terra/price
terra/trade

Import Postman collection & environment file in test/postman/v2 for latest endpoints and request params

gyozajiro · 2021-02-01T11:38:00Z

Client PR for this feature. https://github.com/CoinAlpha/hummingbot/pull/2905.

…code

* Consolidate log into `info`. Remove debug, error, and rejection. * Enable debug mode logging for development * Check for undefined erc20 token list url source * Fix token list conversion for allowance & approval

* accept balancer exchange proxy in .env * accept balancer gas base, gas per swap overwrite in .env * accept eth approval gas limit, manual gas fee setting in .env when ethgasstation not set to true * accept uniswap router setting in .env * accept uniswap gas limit, ttl, update period overwrite * update .env.example

* Add initiate one-time gas retrieval

* Add price check debugging

dennisocana · 2021-03-12T04:41:46Z

Requesting review from @vic-en as well so he can work on the story https://github.com/CoinAlpha/hummingbot/issues/3037

* get on-chain pool data update to prevent change in pool balance prior to trade execution * remove pool cache loop during strategy initialisation

src/routes/uniswap.route.js

…dle approval

…oints

* update start function to use POST to standard request body param (json in particular).

* reduce redundant params being sent over stand POST api call in client

PtrckM · 2021-03-24T12:01:00Z

using the config1
no problem on subsequent orders
however using this config2
resulting with Fail with error 'UniswapV2Router: EXCESSIVE_INPUT_AMOUNT'
also the history are incorrect on uniswap/balancer side
different behavior on balancer using config3

-logs config1 config2 (uniswap)
logs_doonconf.log
logs_uniswap.log

-logs config3 balancer
logs_ditomobile.log

…into feat/optimize_protocol_endpoints

PtrckM · 2021-03-30T08:39:30Z

not able to run gateway, tried on different node versions v10.22.0, v10.22.1 and v10.23.1 all fails. Both mainnet and kovan fails
able to run on both commit e354cbecaac8f6da93f424f453125acf9c462244 and 658429896355eaae3e3a4a0dd3a064f9c2a06e9d without any problems.

PtrckM · 2021-03-30T12:22:58Z

fix issue where gateway can't start
suggested UNISWAP_ALLOWED_SLIPPAGE=1.5

Change not required after code refactor in subsequent commits

vic-en

LGTM

PtrckM

Tested and confirmed working by QA.

gyozajiro requested review from fengtality and vic-en January 30, 2021 13:36

sdgoh added 3 commits February 1, 2021 18:23

(fix) incorrect key param name. add request logging to console

94b10fa

(fix) Uniswap return json key name as info

5c22b1a

(fix) Incorrect request param key name for wallet

895a6b8

jason-hb assigned gyozajiro Feb 1, 2021

sdgoh added 15 commits February 2, 2021 22:31

(feat) Add cache pool refresh timer. Fix Uniswap update token pools

61cc2bc

Default max swap to 4 if not configured. Comment out get-weth test …

9b1816a

…code

(feat) Add fee retrieval from ethgastation base-on .env interval

9c572ff

Add eth gas station param to .env.example

c0fca11

(feat) Retrieve ERC20 token list from external source specific in .env

76ba980

Remove static mainnet erc20 token list file

e938c53

(fix) Remove Winston rejection transport & use handleRejections config

26dbeb8

Consolidate logging into info

1516337

* Consolidate log into `info`. Remove debug, error, and rejection. * Enable debug mode logging for development * Check for undefined erc20 token list url source * Fix token list conversion for allowance & approval

(fix) Uppercase for buy / sell param

21fdada

* Add initiate one-time gas retrieval

(feat) Add gas price, limit, cost info to response json data

8791030

(fix) Uniswap no pool response as error instead of info

aa15575

* Add price check debugging

(feat) check for valid token symbols else return error 500

0a40ecd

Merge branch 'development' into feat/optimize_protocol_endpoints

2a504a8

(feat) Convert proper value for eth gas station set in .env

a1f72ce

dennisocana linked an issue Mar 12, 2021 that may be closed by this pull request

Refactor Gateway endpoint to consolidate functions #36

Closed

sdgoh added 3 commits March 12, 2021 12:49

Remove unnecessary uniswap pool update in /start endpoint

36797e0

(feat) Add Perpetual Finance provider url overwrite

aec0f15

Update balancer on-chain balance on price lookup

54c33ee

* get on-chain pool data update to prevent change in pool balance prior to trade execution * remove pool cache loop during strategy initialisation

vic-en previously requested changes Mar 16, 2021

View reviewed changes

src/routes/uniswap.route.js Outdated Show resolved Hide resolved

vic-en and others added 5 commits March 16, 2021 15:27

Update spender when Uniswap is being used.

9ceb1c8

(refactor) make start endpoint to only initiate pool/path and not han…

2fb292e

…dle approval

Merge branch 'feat/optimize_uniswap' into feat/optimize_protocol_endp…

6f4051b

…oints

(fix) incorrect token update function name

9cbba7d

* update start function to use POST to standard request body param (json in particular).

(fix) revert Uniswap, Balancer start endpoint to GET

f3a8c65

* reduce redundant params being sent over stand POST api call in client

gyozajiro mentioned this pull request Mar 25, 2021

AMM Arb - Uniswap and Balancer transaction errors hummingbot/hummingbot#3114

Closed

vic-en added 2 commits March 29, 2021 21:29

Merge branch 'development' of https://github.com/CoinAlpha/gateway-api …

e354cbe

…into feat/optimize_protocol_endpoints

(feat) allow decimal values for uniswap slippage

95fcfcd

(fix) incorrect mathjs module in package.json

2d8feb0

Add uniswap slippage example using decimal value

c54af16

gyozajiro requested a review from vic-en March 31, 2021 07:03

vic-en approved these changes Mar 31, 2021

View reviewed changes

PtrckM approved these changes Mar 31, 2021

View reviewed changes

vic-en merged commit bf7cc08 into development Mar 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(feat) standard endpoints & consolidate protocol library functions #37

(feat) standard endpoints & consolidate protocol library functions #37

Uh oh!

gyozajiro commented Jan 30, 2021

Uh oh!

gyozajiro commented Jan 30, 2021 •

edited

Loading

Uh oh!

gyozajiro commented Feb 1, 2021

Uh oh!

dennisocana commented Mar 12, 2021

Uh oh!

Uh oh!

PtrckM commented Mar 24, 2021

Uh oh!

PtrckM commented Mar 30, 2021

Uh oh!

PtrckM commented Mar 30, 2021

Uh oh!

vic-en left a comment

Uh oh!

PtrckM left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

(feat) standard endpoints & consolidate protocol library functions #37

(feat) standard endpoints & consolidate protocol library functions #37

Uh oh!

Conversation

gyozajiro commented Jan 30, 2021

Uh oh!

gyozajiro commented Jan 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gyozajiro commented Feb 1, 2021

Uh oh!

dennisocana commented Mar 12, 2021

Uh oh!

Uh oh!

PtrckM commented Mar 24, 2021

Uh oh!

PtrckM commented Mar 30, 2021

Uh oh!

PtrckM commented Mar 30, 2021

Uh oh!

vic-en left a comment

Choose a reason for hiding this comment

Uh oh!

PtrckM left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gyozajiro commented Jan 30, 2021 •

edited

Loading