[Feat] Add approve_delegation_request#18
Merged
BrettCleary merged 3 commits intomainfrom Mar 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the CoinFello CLI to improve security and user control around blockchain delegation signing. Instead of automatically signing delegations when a prompt requires extra permissions, the CLI now saves delegation requests to a file for explicit user review and approval. The documentation has been updated throughout to reflect this new two-step delegation flow, and a new command,
approve_delegation_request, has been introduced.Delegation Flow Redesign and Command Additions:
send_promptcommand no longer signs delegation requests automatically. Instead, it saves the request to a local file (pending_delegation.json) and logs the details to the terminal. Users must now explicitly approve and sign delegations using the newapprove_delegation_requestcommand. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Documentation and Reference Updates:
SKILL.md,REFERENCE.md,README.md) have been updated to describe the new delegation flow, including the newapprove_delegation_requestcommand, expected outputs, and error messages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Configuration and Versioning:
0.3.0to reflect these breaking changes in delegation handling.CONFIG_DIRconstant is now exported fromsrc/config.tsfor use in other modules.Error Handling Improvements:
send_promptbefore attempting to approve a delegation.These changes together make delegation signing more secure and transparent, requiring explicit user consent before any blockchain delegation is signed and submitted.