Skip to content

[Feat] Add approve_delegation_request#18

Merged
BrettCleary merged 3 commits intomainfrom
feat/add_approve_delegation
Mar 17, 2026
Merged

[Feat] Add approve_delegation_request#18
BrettCleary merged 3 commits intomainfrom
feat/add_approve_delegation

Conversation

@BrettCleary
Copy link
Contributor

@BrettCleary BrettCleary commented Mar 17, 2026

This pull request updates the CoinFello CLI to improve security and user control around blockchain delegation signing. Instead of automatically signing delegations when a prompt requires extra permissions, the CLI now saves delegation requests to a file for explicit user review and approval. The documentation has been updated throughout to reflect this new two-step delegation flow, and a new command, approve_delegation_request, has been introduced.

Delegation Flow Redesign and Command Additions:

  • The send_prompt command no longer signs delegation requests automatically. Instead, it saves the request to a local file (pending_delegation.json) and logs the details to the terminal. Users must now explicitly approve and sign delegations using the new approve_delegation_request command. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Documentation and Reference Updates:

  • All relevant documentation files (SKILL.md, REFERENCE.md, README.md) have been updated to describe the new delegation flow, including the new approve_delegation_request command, expected outputs, and error messages. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Configuration and Versioning:

  • The CLI version is bumped to 0.3.0 to reflect these breaking changes in delegation handling.
  • The CONFIG_DIR constant is now exported from src/config.ts for use in other modules.

Error Handling Improvements:

  • New error messages have been added for missing pending delegation requests, guiding users to run send_prompt before attempting to approve a delegation.

These changes together make delegation signing more secure and transparent, requiring explicit user consent before any blockchain delegation is signed and submitted.

@BrettCleary BrettCleary self-assigned this Mar 17, 2026
@BrettCleary BrettCleary merged commit f675f26 into main Mar 17, 2026
2 checks passed
@BrettCleary BrettCleary deleted the feat/add_approve_delegation branch March 17, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant