Skip to content

Change updateBoxJsonAIConfig() to use readPackageDescriptorRaw()#35

Merged
bdw429s merged 1 commit intoColdBox:developmentfrom
Leftbower:fix-setting-placeholder-resolve-issue
Mar 10, 2026
Merged

Change updateBoxJsonAIConfig() to use readPackageDescriptorRaw()#35
bdw429s merged 1 commit intoColdBox:developmentfrom
Leftbower:fix-setting-placeholder-resolve-issue

Conversation

@Leftbower
Copy link
Contributor

Description

AIService.updateBoxJsonAIConfig() was modifying the box.json with the resolved values of settings placeholder variables (e.g. ${GITHUB_ACCESS_TOKEN})

Please note that all PRs must have tests attached to them

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Issues

All PRs must have an accompanied issue. Please make sure you created it and linked it here.

Type of change

Please delete options that are not relevant.

  • Bug Fix

Checklist

  • My code follows the style guidelines of this project cfformat

@bdw429s bdw429s merged commit c66f9f3 into ColdBox:development Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants