feat(shared): slack integration settings types + validation

[ColeMurray]

Summary

PR 2 of the agent-slack-notification feature (plan). Defines the typed shape of Slack integration settings and wires it through the IntegrationSettingsStore with strict per-level validation. No behavior change to anything that exists today — Slack settings are not yet read or used anywhere; that arrives in PRs 3–5.

• Adds "slack" to IntegrationId, IntegrationSettingsMap, and INTEGRATION_DEFINITIONS.
• Defines SlackRepoSettings (master switch only) and SlackGlobalSettings (master switch + workspace mentions policy). The spec calls out mentions policy as global only — not overridable per repo, and the validator enforces it.
• Adds a level: "global" | "repo" parameter to the existing IntegrationSettingsStore.validateAndNormalizeSettings dispatcher and a validateSlackSettings private method that:
  • Rejects unknown fields at both levels
  • Rejects mentionsPolicy at the per-repo level
  • Rejects non-boolean agentNotificationsEnabled
  • Rejects mentionsPolicy values outside { "allow", "escape", "strip" }

Behavior changes

• The integrations list in Settings will now include a "Slack" row. Clicking it routes to a page that currently renders nothing (the IntegrationDetail switch in [id]/page.tsx falls through to null). PR 3 lands the actual UI.
• The /integration-settings/slack/... API endpoints are now reachable (they go through the existing generic handlers). Operators could curl them today, but there's no UI yet.

What's intentionally NOT here

• No D1 migration. integration_settings and integration_repo_settings already store opaque JSON keyed by integration_id; nothing schema-shaped needs to change.
• No web UI. That's PR 3.
• No control-plane handler / Slack call path. That's PR 4.
• No defaults applied at storage time. The plan's "default false / default 'allow'" applies at consumer time (PR 4 will resolve effective config); the store stays consistent with how GitHubBotSettings etc. handle defaults today (all fields optional, consumers fill in).

Naming deviation from spec/plan pseudocode

The spec and plan show field names in snake_case (agent_notifications_enabled, mentions_policy). The codebase universally uses camelCase for settings fields (autoReviewOnOpen, allowedTriggerUsers, tunnelPorts, terminalEnabled). I treated the snake_case as pseudocode and used camelCase here to match existing conventions and avoid making this integration the odd one out.

Type design note

IntegrationEntry<TRepo> couples the global defaults and per-repo settings to a single TRepo type. Since mentionsPolicy is global-only but agentNotificationsEnabled is shared, I used IntegrationEntry<SlackGlobalSettings> (the wider type) and enforce the constraint at validation time via the new level parameter. SlackRepoSettings is exported as documentation of intent — it's the narrower view of what's allowed at the per-repo level, which the validator enforces.

Test plan

• npm test -w @open-inspect/control-plane — 1063/1063, including 12 new slack-specific cases (round-trip, accept-all-policies, reject invalid mentionsPolicy, reject non-boolean, reject unknown field at both levels, reject mentionsPolicy at per-repo level, getResolvedConfig merge, mentionsPolicy comes from global only)
• npm test -w @open-inspect/shared — 135/135
• npm test -w @open-inspect/slack-bot — 48/48 (no behavior change)
• npm test -w @open-inspect/web — 208/208
• npm test -w @open-inspect/github-bot — 103/103
• npm test -w @open-inspect/linear-bot — 103/103
• npm run test:integration -w @open-inspect/control-plane — 327/327
• npm run typecheck — clean across all packages
• npm run lint — clean
• npm run format -- --check — clean

Files

• packages/shared/src/types/integrations.ts (+21/-3)
• packages/control-plane/src/db/integration-settings.ts (+53/-2)
• packages/control-plane/src/db/integration-settings.test.ts (+121/-3, including flipping the existing expect(isValidIntegrationId("slack")).toBe(false) to true)

Summary by CodeRabbit

• New Features
  • Added Slack integration with configurable global and per-repository settings; options include mentions policy and agent notifications, with per-repo overriding agent notifications.
• Validation
  • Enforces allowed fields for global vs repo settings, restricts mentions policy values, and rejects unknown fields.
• Tests
  • Added comprehensive Slack settings tests covering CRUD, validation, and resolved-config merge rules.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0781bb75-5acd-4b75-85f8-17591813f736

📥 Commits

Reviewing files that changed from the base of the PR and between c66e287 and 551fc83.

📒 Files selected for processing (2)

• packages/control-plane/src/db/integration-settings.ts
• packages/shared/src/types/integrations.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• packages/shared/src/types/integrations.ts
• packages/control-plane/src/db/integration-settings.ts

---

📝 Walkthrough

Walkthrough

Adds Slack integration types and a Slack entry in integration definitions; threads a SettingsLevel into validateAndNormalizeSettings; implements validateSlackSettings enforcing level-specific allowed keys and value constraints; updates setGlobal/setRepoSettings to pass level; adjusts getResolvedConfig typing; and adds comprehensive Slack tests.

Changes

Slack Integration Settings Support

Layer / File(s)	Summary
Slack Type Definitions packages/shared/src/types/integrations.ts	IntegrationId includes "slack". Adds SlackMentionsPolicy, SlackRepoSettings, SlackGlobalSettings. Extends IntegrationEntry generics so global.defaults uses the global type. Adds slack to IntegrationSettingsMap, SlackGlobalConfig derived type, and INTEGRATION_DEFINITIONS entry.
Validation Constants & Function Signatures packages/control-plane/src/db/integration-settings.ts	Adds internal SettingsLevel (`"global"
Slack Validation Implementation packages/control-plane/src/db/integration-settings.ts	Adds validateSlackSettings(settings, level) enforcing allowed keys per level (global: agentNotificationsEnabled, mentionsPolicy; repo: agentNotificationsEnabled), validates boolean agentNotificationsEnabled, and restricts mentionsPolicy to allowed values.
Store Integration packages/control-plane/src/db/integration-settings.ts	setGlobal calls validation with level "global"; setRepoSettings calls validation with level "repo" before persisting.
Resolved Config Typing packages/control-plane/src/db/integration-settings.ts	getResolvedConfig return generic now uses NonNullable<IntegrationSettingsMap[K]["global"]["defaults"]>.
Slack Settings Tests packages/control-plane/src/db/integration-settings.test.ts	isValidIntegrationId updated to accept "slack". New Slack test suite added covering global and per-repo CRUD round-trips, validation error cases, unknown field rejection, and resolved-config merge behavior (repo agentNotificationsEnabled overrides global; mentionsPolicy comes from global).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through types and tests so bright,

Slack joined the list and rules took flight.
Global defaults and repo small tweaks,
Validation watches for the sneaky leaks.
A carrot, a nod — the settings now speak.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'feat(shared): slack integration settings types + validation' accurately and directly summarizes the main change—adding Slack integration types and validation logic—which aligns with the primary alterations across the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/slack-integration-types

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Terraform Validation Results

Step	Status
Format	✅
Init	✅
Validate	✅

Note: Terraform plan was skipped because secrets are not configured. This is expected for external contributors. See docs/GETTING_STARTED.md for setup instructions.

Pushed by: @ColeMurray, Action: pull_request

[open-inspect]

Summary

PR #607, feat(shared): slack integration settings types + validation, by @ColeMurray adds Slack integration settings types in shared and wires Slack validation through IntegrationSettingsStore. I reviewed the 3 changed files (+190/-5) and found one blocking type-contract mismatch; inline comment posted.

Critical Issues

• [Functionality & Correctness] packages/shared/src/types/integrations.ts:68 - IntegrationSettingsMap["slack"]["repo"] is still typed as SlackGlobalSettings, so downstream callers can type-check repo payloads containing mentionsPolicy even though the new store validation rejects that field at runtime. This makes the exported shared types disagree with the actual API contract for per-repo Slack settings.

Suggestions

• None.

Nitpicks

• None.

Positive Feedback

• The new store-level validation is straightforward and consistently enforces the allowed Slack keys and value shapes.
• The Slack test coverage is solid for both acceptance and rejection paths, including resolved-config behavior.
• Reusing the existing integration settings plumbing keeps the change small and easy to follow.

Questions

• None.

Verdict

Request Changes: the shared repo-level Slack type should match the runtime contract before this lands.

[coderabbitai]

🧹 Nitpick comments (1)

packages/shared/src/types/integrations.ts (1)

62-69: 🏗️ Heavy lift

Slack repo typing is broader than intended (global-only field allowed at compile time).

IntegrationEntry<SlackGlobalSettings> makes repo accept mentionsPolicy, so invalid repo payloads type-check and only fail at runtime validation. Consider modeling Slack with distinct global/repo shapes in IntegrationSettingsMap to enforce the per-level contract at compile time too.

♻️ Suggested direction

 export interface IntegrationSettingsMap {
   github: IntegrationEntry<GitHubBotSettings>;
   linear: IntegrationEntry<LinearBotSettings>;
   "code-server": IntegrationEntry<CodeServerSettings>;
   sandbox: IntegrationEntry<SandboxSettings>;
-  slack: IntegrationEntry<SlackGlobalSettings>;
+  slack: {
+    global: {
+      enabledRepos?: string[];
+      defaults?: SlackGlobalSettings;
+    };
+    repo: SlackRepoSettings;
+  };
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/shared/src/types/integrations.ts` around lines 62 - 69,
IntegrationSettingsMap currently uses IntegrationEntry<SlackGlobalSettings>
which lets repo-level data include global-only fields like mentionsPolicy;
define a separate SlackRepoSettings type (omitting mentionsPolicy and any other
global-only fields) and change the Slack entry to use the IntegrationEntry
specialization that accepts distinct global and repo shapes (e.g.,
IntegrationEntry<SlackGlobalSettings, SlackRepoSettings>), updating
imports/exports accordingly so repo payloads are statically constrained to the
repo shape.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@packages/shared/src/types/integrations.ts`:
- Around line 62-69: IntegrationSettingsMap currently uses
IntegrationEntry<SlackGlobalSettings> which lets repo-level data include
global-only fields like mentionsPolicy; define a separate SlackRepoSettings type
(omitting mentionsPolicy and any other global-only fields) and change the Slack
entry to use the IntegrationEntry specialization that accepts distinct global
and repo shapes (e.g., IntegrationEntry<SlackGlobalSettings,
SlackRepoSettings>), updating imports/exports accordingly so repo payloads are
statically constrained to the repo shape.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1d7d7f0a-f711-4d2f-bf0d-a874de1ee9da

📥 Commits

Reviewing files that changed from the base of the PR and between cb00e23 and c66e287.

📒 Files selected for processing (3)

• packages/control-plane/src/db/integration-settings.test.ts
• packages/control-plane/src/db/integration-settings.ts
• packages/shared/src/types/integrations.ts

[github-actions]

Terraform Validation Results

Step	Status
Format	✅
Init	✅
Validate	✅

Note: Terraform plan was skipped because secrets are not configured. This is expected for external contributors. See docs/GETTING_STARTED.md for setup instructions.

Pushed by: @ColeMurray, Action: pull_request

.