fix(config): add conversation agent to api.yaml to fix release gate CI#205
Merged
Merged
Conversation
…erf test
Root cause: configs/api.yaml had no agents: section, so bootstrap.Config.Agents.Agents
was empty and the len > 0 guard skipped RegisterConfiguredAgents(). As a result,
manager.Get("conversation") returned nil and AgentMessage() returned HTTP 404.
Fix: add agents.agents.conversation (type react) directly in api.yaml so the v1
runtime manager registers it at startup and perf test requests receive HTTP 202.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Release Gates CI performance tests failing with HTTP 404 {"error":"Agent not found"} by ensuring the API’s primary runtime config (configs/api.yaml) includes an agents section registering the conversation agent, so POST /api/agents/conversation/message can resolve the agent and return 202 instead of 404.
Changes:
- Add an
agents.agents.conversationentry toconfigs/api.yamlso the API registers theconversationagent at startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Release Gates CI 的性能测试全部返回
HTTP 404 {"error":"Agent not found"}。根因
configs/api.yaml(API 二进制实际加载的配置文件)中没有agents:段,导致:bootstrap.Config.Agents.Agents为空 mapapp.go中len(bootstrap.Config.Agents.Agents) > 0的守卫条件失败RegisterConfiguredAgents()和agentFactory.GetOrCreateFromConfig()均被跳过AgentMessage()handler 调用manager.Get("conversation")返回 nil → 返回 404修复
在
configs/api.yaml末尾追加agents:段,注册conversationagent(type: react)。API 启动时
RegisterConfiguredAgents()会在 v1 manager 中注册该 agent,AgentMessage()返回 HTTP 202。验证路径
CI 性能测试流程: