Fix UB in NtUnicodeStrMut::try_from_u16()#2
Merged
Conversation
smichaku
force-pushed
the
fix-try_from_u16
branch
from
fa91cd9 to
3d03d4d
Compare
Avoid transmuting an NtUnicodeStr into a NtUnicodeStrMut which is assigned a *const instead of a *mut for its buffer field.
smichaku
force-pushed
the
fix-try_from_u16
branch
from
3d03d4d to
8d4d3b4
Compare
Owner
|
Hey @smichaku, thanks a lot for your PR! This doesn't only fix the UB you reported in #1, but also eliminates a few I took the liberty to move your newly added functions back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid transmuting an NtUnicodeStr into a NtUnicodeStrMut which is assigned a *const instead of a *mut for its buffer field.