Private/caolan/coverity20250516 #11966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: If6cdaad28a3e4a997875dc8c58b3f9686e4992e5
and cid#512069 Variable copied when it could be moved Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I0fa1413de8b3fc357afe82bd7dc676d808b69f27
Ashod
reviewed
May 19, 2025
|
|
||
| bool calledFailed = false; | ||
| http::Session::ConnectFailCallback connectFailCallback = | ||
| [&](const std::shared_ptr<http::Session>&) { calledFailed = true; }; |
Ashod
approved these changes
May 19, 2025
|
|
||
| // Is it outdated? | ||
| if (dstStat.isUpToDate(srcStat)) | ||
| if (FileUtil::Stat::isUpToDate(srcStat, srcFilename, dstStat, dstFilename)) |
Contributor
There was a problem hiding this comment.
This looks cumbersome. I suppose JailUtil being the only place we use isUpToDate() it's acceptable. Although I'm not sure removing _path is such a big win. Perhaps I forgot the reason behind it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay