Private/caolan/coverity20250517 #11968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I81a36e992b961ed1b2426c6ee9d6cf8238151520
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I2937e969f2a79e4cc64a52d82f24ed1e3e931ad7
Contributor
Author
|
coverity flags that a mutex is held to write to ErrorsStream but not to read from it. Adding that looks safe. |
vmiklos
approved these changes
May 19, 2025
| // output the ErrorsStream we got during the testing | ||
| if (!result.wasSuccessful()) | ||
| { | ||
| std::lock_guard<std::mutex> lock(ErrorMutex); |
Contributor
There was a problem hiding this comment.
Reading the commit message of 0c46b33, this is indeed used from multiple threads, so then makes sense. First this looked strange, since we clearly ask cppunit to run tests in a suite only on a single thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay