fix: resolving duplicate event subscriptions#129
Merged
Conversation
Event subscribers were created from a list of instance subscriptions, which caused duplicate subscriptions per scheduled instance in the runtime. This led to duplicate event delivery to state machines. Use a set instead of a list to eliminate duplicate subscribers.
Frnd-me
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The subscribers for events from each source (instance) were being created based on a list of instances' subscriptions. This lead to duplicate subscriptions (n, where n = number of scheduled instances in the runtime) and thereby delivery of duplicate events to state machines. Converted the list to a set to eliminate duplicate subscribers.
Type of change
How has this been tested?
Using existing unit and integration tests. Also added a new test to check that duplicate event delivery is prevented.
All tests pass.