Modify the translator name and add the translator in README.md #835
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the translator name from "SatoSouta" to "CatSouta" in the Simplified Chinese translation file and adds the new CatSouta contributor entry to the README contributors table.
- Updated the author name from "SatoSouta" to "CatSouta" in the zh_CN.json language file
- Added a new contributor entry for CatSouta in the README.md contributors table
- Incidentally updated URL query parameters from
?s=100to&s=100for existing GitHub avatar URLs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Added new CatSouta contributor entry to the contributors table and fixed URL query parameter syntax for avatar images |
| Hi3Helper.Core/Lang/zh_CN.json | Updated translator author name from "SatoSouta" to "CatSouta" in the author field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <tr> | ||
| <td align="center" valign="top" width="14.28%"><a href="https://souta.cc"><img src="https://avatars.githubusercontent.com/u/18072048?v=4&s=100" width="100px;" alt="CatSouta"/><br /><sub><b>CatSouta</b></sub></a><br /><a href="#translation-CatSouta" title="Translation">🌍</a></td> | ||
| </tr> |
There was a problem hiding this comment.
Inconsistent indentation detected in the new table row. Lines 163 and 165 use tabs for indentation, while all other table rows in the file use spaces (2 spaces for indentation). This breaks the formatting consistency of the contributor table. Please change the tabs to spaces to match the existing indentation pattern.
| <tr> | |
| <td align="center" valign="top" width="14.28%"><a href="https://souta.cc"><img src="https://avatars.githubusercontent.com/u/18072048?v=4&s=100" width="100px;" alt="CatSouta"/><br /><sub><b>CatSouta</b></sub></a><br /><a href="#translation-CatSouta" title="Translation">🌍</a></td> | |
| </tr> | |
| <tr> | |
| <td align="center" valign="top" width="14.28%"><a href="https://souta.cc"><img src="https://avatars.githubusercontent.com/u/18072048?v=4&s=100" width="100px;" alt="CatSouta"/><br /><sub><b>CatSouta</b></sub></a><br /><a href="#translation-CatSouta" title="Translation">🌍</a></td> | |
| </tr> |
|
Contributers in README.md is generated: https://github.com/CollapseLauncher/Collapse/blob/main/.all-contributorsrc |
|
@all-contributors please add @CatSouta for translation |
|
@all-contributors please add @CatSouta for translation |
|
I've put up a pull request to add @CatSouta! 🎉 |
|
@CatSouta We've gone ahead and added you to the list of contributors on the project. For in-launcher credits, we've also changed the name on Transifex. In the future, should your name change, please change it in Transifex first so that we can approve it. The GitHub name will automatically update, so no worries there. Ref: #840 Closing! |
Adds @CatSouta as a contributor for translation. This was requested by Cryotechnic [in this comment](#835 (comment)) [skip ci]
4 participants
Main Goal
I used to contribute Simplified Chinese translations on Crowdin, and my ID was SatoSouta, but it has now been changed to CatSouta.