CRITICAL: Fix double dispose on LazyLoadBitmap #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is caused by the `using` clause on the stream causing the resultStream to somehow getting double disposed during the event `ImageOnImageOpened` and crashes about 95% of the time during game/region change.
bagusnl
added
Bug
Member
Author
|
This fix does work atm but causes memory bloating. Trying to find another solution... |
Member
Author
|
False alarm, memory bloating only occurs when you load plugin subsystem: Only tested for HBR plugin atm, but worth looking at another time |
Member
Author
|
@sentry review |
Cryotechnic
approved these changes
Dec 19, 2025
Member
Cryotechnic
left a comment
Cryotechnic
left a comment
There was a problem hiding this comment.
The memory spike is not an issue and will also get GC'ed, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Goal
Tryfix for launcher crash due to ODE during game/region switch.
This is caused by the
usingclause on the stream causing the resultStream to somehow getting double disposed during the eventImageOnImageOpenedand crashes about 95% of the time during game/region change.PR Status :
Templates
Changelog Prefixes