Stable 1.83.18 Hotfix #878
Merged
Merged
Conversation
Comment on lines
+106
to
+109
| if (!urlStatus.IsSuccessStatusCode) | ||
| { | ||
| throw new HttpRequestException("No Asset bundle URLs were reachable"); | ||
| } |
There was a problem hiding this comment.
Bug: The asset fetching logic was changed from retrying multiple URLs to using a single random URL, causing the entire repair process to fail if that one URL is unavailable.
Severity: HIGH
Suggested Fix
Restore the previous logic of iterating through all available gameServerInfo.ExternalAssetUrls. For each asset, attempt to fetch it from each base URL in the list until one succeeds. Only throw an exception if all URLs for a given asset have been tried and have failed. This will restore resilience against transient CDN or network failures.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
CollapseLauncher/Classes/RepairManagement/HonkaiV2/HonkaiRepairV2.AsbExt.Audio.cs#L106-L109
Potential issue: The refactoring of audio and video asset fetching has removed the
resilience of the previous implementation. The old code would iterate through multiple
base URLs if one failed, but the new code selects a single random URL using
`GetRandomAsbBaseUrl`. If this single URL is unavailable for any reason (e.g., transient
CDN issue, regional outage), an `HttpRequestException` is thrown. This exception is not
caught downstream and propagates up to a `Task.WhenAll`, causing the entire game repair
process to fail. The previous logic would have gracefully tried another URL or skipped
the asset.
Also affects:
CollapseLauncher/Classes/RepairManagement/HonkaiV2/HonkaiRepairV2.AsbExt.Video.cs:138~143
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed? - 1.83.18
HttpRequestException, by @neon-nyanstreamingasb:80URL while downloading in some cases, by @neon-nyanFull Changelog: CL-v1.83.17...CL-v1.83.18
Code Signing Policy