Upgrade to .NET 10 #2
Conversation
Signed-off-by: Bagus Nur Listiyono <dzakibagus@gmail.com>
Also reducing stackalloc size from 64 to 32 bytes in ToString() method
Add profile for DNA to launch settings
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Technically, no one would use any Major, Minor and Build version number beyond ushort.MaxValue. In any-case, the ToString should be able to print the most maximum (non-sense) characters, which is 47 characters long as follows: -2147483648.-2147483648.-2147483648.-2147483648
There was a problem hiding this comment.
Aside from GameVersion fix, everything should be looking good.
For now, I'm planning to rebase-merge this branch as some commits on main branch are cherry-picked from this net-10 branch, causing duplicated commits and merge-conflict. Let me know any changes to put before we can merge this.
Not sure if this is final, but there was a change made by @gablm to add support for resizeable window hooks: 6ea20a8 If we're already planning to merge .NET 10, it could be a good idea to merge that too (if that's finalized). I've tagged them here and on Discord to validate if we can proceed with that merge. If anything, we can also merge the current .NET 10 changes and merge the hook changes later. |
Due to .NET 10 hitting GA in early November, this PR aims to bring it in line with the other dependencies for Collapse.