Encountered bugs whilst using RGFW, suggestions for RGFW

[EimaKve]

Major/must-be resolved issues

Issue 1: High amounts of warnings on clang
Compiling RGFW on Linux with clang and its options -std=c99 -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wvla -Wcast-align -Wcast-align=strict -Wswitch-enum -Wcast-align -Wstrict-overfl ow -Wstrict-prototypes -Wnested-externs -Wlogical-op -Wstrict-aliasing -Wredundant-decls -Wold-style-definition -fno-omit-frame-pointer -ffloat-store -fstrict-aliasing -Wformat=2 -Wformat-signedness -Wuninitialized -W init-self -Wunsafe-loop-optimizations -Wmissing-noreturn results in around 153 warnings. A lot of these warnings related to missing prototypes, signedness and portability issues. It's also worth mentioning that there are probably even more warnings when compiling under gcc and/or the -O3 flag.

Issue 2: High amounts of warnings on msvc
Compiling RGFW with cl and its options -nologo -std:c11 -Wall -wd4668 -wd4820 -wd5045 results in warnings in quite a few areas.

Issue 3: Smooth resize on Linux
Smooth resizing completely doesn't work on Linux. See the smooth resize example.

Issue 4: Dummy window sometimes appearing
Sometimes when compiling and running the gl33 example on Linux, a dummy window gets visibly created and immediately deleted, causing an ugly effect.

# Secondary issues
Issue 1: #pragma clang diagnostic ignored "-Wnullability-completeness"
At the beginning and end of the RGFW.h file, there are diagnostic warning checks for clang to ignore a specific warning. This is pretty bad code practice for a single header library.

[DiarrheaMcgee]

il try to go through some of them today

[ColleagueRiley]

@EimaMei Most of these issues seem to be solved, can you confirm?

[EimaKve]

Almost all of the above issues have been fixed except for a few small issues.

There is some leftover warnings from wayland code

clang -std=c11 -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wvla -Wcast-align -Wcast-align=strict -Wswitch-enum -Wcast-align -Wstrict-overfl
ow -Wstrict-prototypes -Wnested-externs -Wlogical-op -Wstrict-aliasing  -Wredundant-decls -Wold-style-definition -fno-omit-frame-pointer -ffloat-store -fstrict-aliasing -Wformat=2 -Wformat-signedness -Wuninitialized -W
init-self -Wunsafe-loop-optimizations -Wmissing-noreturn -D _GNU_SOURCE -D _LARGEFILE64_SOURCE -D __USE_POSIX199506 -I"." -I"include" -fPIC -c src/deps/RGFW.c -o"build/RGFW.o"
clang: warning: optimization flag '-ffloat-store' is not supported [-Wignored-optimization-argument]
warning: unknown warning option '-Wcast-align=strict'; did you mean '-Wcast-align'? [-Wunknown-warning-option]
warning: unknown warning option '-Wlogical-op'; did you mean '-Wlong-long'? [-Wunknown-warning-option]
warning: unknown warning option '-Wunsafe-loop-optimizations' [-Wunknown-warning-option]
In file included from src/deps/RGFW.c:2:
./include/deps/RGFW.h:1509:11: warning: no previous prototype for function 'RGFW_usingWayland' [-Wmissing-prototypes]
 1509 | RGFW_bool RGFW_usingWayland(void) { return RGFW_useWaylandBool; }
      |           ^
./include/deps/RGFW.h:1509:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
 1509 | RGFW_bool RGFW_usingWayland(void) { return RGFW_useWaylandBool; }
      | ^
      | static 
./include/deps/RGFW.h:306:20: note: expanded from macro 'RGFW_bool'
  306 |         #define RGFW_bool u8
      |                           ^
./include/deps/RGFW.h:301:13: note: expanded from macro 'u8'
  301 |         #define u8 u8
      |                    ^
4 warnings generated.

The "dummy" window issue is still present. In the attached video you can also see how the window is first created at the most top-left coordinate of the screen. The gl33 example also still has the "dummy" window issue, although it doesn't seem like the position offset is set to 0,0

11-07-37.mp4

[EimaKve]

Pretty much everything has been solved. The only other nitpick that I can bring up is in some of the examples there are minor warnings relating to undefined prototypes. Other than that, everything is good now.

cc -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wvla -Wcast-align -Wcast-align=strict -Wswitch-enum -Wcast-align -Wstrict-overflow -Wstrict-prototypes -Wnested-externs -Wlogical-op -Wstrict-aliasing -Wredundant-decls -Wold-style-definition -fno-omit-frame-pointer -ffloat-store -fstrict-aliasing -Wformat=2 -Wformat-signedness -Wuninitialized -Winit-self -Wunsafe-loop-optimizations -Wmissing-noreturn -I. examples/gl33_ctx/gl33_ctx.c -lGL -lXrandr -lX11 -ldl -lpthread -std=c99 -o examples/gl33_ctx/gl33_ctx
cc -Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion -Wshadow -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wvla -Wcast-align -Wcast-align=strict -Wswitch-enum -Wcast-align -Wstrict-overflow -Wstrict-prototypes -Wnested-externs -Wlogical-op -Wstrict-aliasing -Wredundant-decls -Wold-style-definition -fno-omit-frame-pointer -ffloat-store -fstrict-aliasing -Wformat=2 -Wformat-signedness -Wuninitialized -Winit-self -Wunsafe-loop-optimizations -Wmissing-noreturn -I. examples/smooth-resize/smooth-resize.c -lGL -lXrandr -lX11 -ldl -lpthread -std=c99 -o examples/smooth-resize/smooth-resize
examples/smooth-resize/smooth-resize.c:7:6: warning: no previous prototype for ‘draw’ [-Wmissing-prototypes]
7 | void draw(RGFW_window* win) {
| ^~~~
examples/smooth-resize/smooth-resize.c:22:6: warning: no previous prototype for ‘resize’ [-Wmissing-prototypes]
22 | void resize(RGFW_window* win, RGFW_rect rect) { RGFW_UNUSED(win); glViewport(0, 0, rect.w, rect.h); }
| ^~~~~~
examples/smooth-resize/smooth-resize.c:23:6: warning: no previous prototype for ‘refresh’ [-Wmissing-prototypes]
23 | void refresh(RGFW_window* win) { printf("refresh\n"); RGFW_UNUSED(win); draw(win); }

examples/multi-window/multi-window.c:6:6: warning: no previous prototype for ‘checkEvents’ [-Wmissing-prototypes]
6 | void checkEvents(RGFW_window* win) {
| ^~~~~~~~~~~
examples/multi-window/multi-window.c:45:7: warning: no previous prototype for ‘loop’ [-Wmissing-prototypes]
45 | void* loop(void* _win) {

[ColleagueRiley]

Those are related to new examples, I will fix those.