Feature/curry dictionary updates #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated it to take an equality function over values
Intentionally returning false value to support red-green TDD
This is due to the new running Count Exposing a private var would allow uncontrollable state mutations, and a bad count
Non-matching keys will always now just be ignored & 0 returned, regardless or arity
Also updated the BinaryDigit - see changelog
This makes the updates to the underlying curry dictionary a bit safer It means that the curry dictionary code accessing that underlying dictionary must explicitly consider count every time
This ensures listeners i.e. parent objects are notified whenever count is updated
Also added some tests of the nullary cases Also updated immutable validated to override equals and hashcode
Need to throw argument exception outside of the yield-return function as the yield-return is lazily evaluated
Also updated curry dictionary entry to be BREAKING as there were some renames of properties/methods
puniththota
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced curry dictionary with new properties and methods. Also added enhancements for event wrappers, dictionary extension methods, and the immutable validated type. See CHANGELOG and/or linked issues for more detail.
Closes #109
Closes #111
Closes #112
Closes #113