Feature/list map #53
Merged
Feature/list map #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased functionality out
C# already has a library with a ListDictionary in it which means something else So to disambiguate, the names of these collection-valued dicts include the term "Valued" indicating that it's the values at each key that is a collection
The C# underlying dictionary will throw this anyway, but no harm pushing the error up a level in the stack trace
This function allows a user to insert an element to a given index in the list at the given key One test case is where there is already a non-mepty list mapped from the given key Another test case is where there is no list mapped to the given key- confirming that insert creates one
PR number on each line relating to this PR Added a line about list-valued dictionaries
This was
linked to
issues
Jun 26, 2020
Closed
hctrdev
requested changes
Jun 29, 2020
hctrdev
previously approved these changes
Jun 30, 2020
hctrdev
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the MultiValueMap to something more abstract. Renamed the types to be less ambiguous. Added a list-valued map.
As an aside, removed the getHashCode() function and replaced with equals with a
DictEqualsfunction.