Feature/dictionary enhancements #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtially cast More info here: https://stackoverflow.com/a/62720142/5134722
…ould be useful in future.
Flatten unrolls the array to either row major or column major order
…e precedence We want the one-based version to take precedence for a one-based array
This was
linked to
issues
Jul 6, 2020
Closed
hctrdev
requested changes
Jul 6, 2020
| /// <summary> | ||
| /// Converts this array to a reverse list-based dictionary | ||
| /// </summary> | ||
| public static IListValuedDictionary<TVal, int> ConvertToReverseListValuedDictionary<TVal>(this TVal[] array, int indexOffset) |
Collaborator
There was a problem hiding this comment.
I think it makes sense to add overrides for these functions that default the offset to 0. I think it's great that you support it, but I don't see many cases where they would be used (aside from one-based arrays, but they probably should implement a version of this that automatically sets the offset to 1 to avoid confusion).
| ISuccessTuple<V> TryGetValue(K key); | ||
| } | ||
|
|
||
| public interface ISuccessTuple<out V> |
Collaborator
There was a problem hiding this comment.
You might want to split this into its own file. Same for the implementation class below.
hctrdev
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some enhancements to dictionaries covering some outstanding issues, including: