Added tests to variant dictionary methods #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColmBhandal
reviewed
Jul 15, 2020
Owner
There was a problem hiding this comment.
Need more tests for these functions: IsReadOnly, Keys, Values.
Also should rename tests with Given_When_Then syntax so that they describe exactly what's being tested.
TryGetValueTest should test the out value rather than just the success- if this is the case for dictionary tests too then these should be fixed.
This was
linked to
issues
Jul 15, 2020
Closed
added 3 commits
July 16, 2020 12:49
# Conflicts: # CsharpExtras/Map/Dictionary/Variant/IVariantDictionary.cs
ColmBhandal
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the tests to the variant dictionary methods and resolved the ambiguity by hiding the methods